5c5478d774
The current approach with separate ResourceDetail classes suffers from serious flows and is barely usable. For example for nodes: * get_node() returns complete Node objects * nodes() returns incomplete Node objects * nodes(details=True) returns NodeDetail objects, which are exactly like complete Node objects, except that you cannot do anything with them: updating, listing VIFs, etc. This is confusing and essentially requires the caller to issue a redundant get_node call after listing detailed nodes. This change consolidates everything into Node (Port, etc) objects and deprecates NodeDetail (PortDetail, etc). I would highly recommend the same approach taken for other ResourceDetail objects. Change-Id: Idedee2b394e2ed412a69880d4bc9315737e1c3ed
174 lines
7.6 KiB
Python
174 lines
7.6 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import uuid
|
|
|
|
from openstack import exceptions
|
|
from openstack.tests.functional.baremetal import base
|
|
|
|
|
|
class TestBareMetalNode(base.BaseBaremetalTest):
|
|
def test_node_create_get_delete(self):
|
|
node = self.create_node(name='node-name')
|
|
self.assertEqual(node.name, 'node-name')
|
|
self.assertEqual(node.driver, 'fake-hardware')
|
|
self.assertEqual(node.provision_state, 'available')
|
|
self.assertFalse(node.is_maintenance)
|
|
|
|
# NOTE(dtantsur): get_node and find_node only differ in handing missing
|
|
# nodes, otherwise they are identical.
|
|
for call, ident in [(self.conn.baremetal.get_node, self.node_id),
|
|
(self.conn.baremetal.get_node, 'node-name'),
|
|
(self.conn.baremetal.find_node, self.node_id),
|
|
(self.conn.baremetal.find_node, 'node-name')]:
|
|
found = call(ident)
|
|
self.assertEqual(node.id, found.id)
|
|
self.assertEqual(node.name, found.name)
|
|
|
|
nodes = self.conn.baremetal.nodes()
|
|
self.assertIn(node.id, [n.id for n in nodes])
|
|
|
|
self.conn.baremetal.delete_node(node, ignore_missing=False)
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.get_node, self.node_id)
|
|
|
|
def test_node_update(self):
|
|
node = self.create_node(name='node-name', extra={'foo': 'bar'})
|
|
node.name = 'new-name'
|
|
node.extra = {'answer': 42}
|
|
instance_uuid = str(uuid.uuid4())
|
|
|
|
node = self.conn.baremetal.update_node(node,
|
|
instance_id=instance_uuid)
|
|
self.assertEqual('new-name', node.name)
|
|
self.assertEqual({'answer': 42}, node.extra)
|
|
self.assertEqual(instance_uuid, node.instance_id)
|
|
|
|
node = self.conn.baremetal.get_node('new-name')
|
|
self.assertEqual('new-name', node.name)
|
|
self.assertEqual({'answer': 42}, node.extra)
|
|
self.assertEqual(instance_uuid, node.instance_id)
|
|
|
|
node = self.conn.baremetal.update_node(node,
|
|
instance_id=None)
|
|
self.assertIsNone(node.instance_id)
|
|
|
|
node = self.conn.baremetal.get_node('new-name')
|
|
self.assertIsNone(node.instance_id)
|
|
|
|
def test_node_update_by_name(self):
|
|
self.create_node(name='node-name', extra={'foo': 'bar'})
|
|
instance_uuid = str(uuid.uuid4())
|
|
|
|
node = self.conn.baremetal.update_node('node-name',
|
|
instance_id=instance_uuid,
|
|
extra={'answer': 42})
|
|
self.assertEqual({'answer': 42}, node.extra)
|
|
self.assertEqual(instance_uuid, node.instance_id)
|
|
|
|
node = self.conn.baremetal.get_node('node-name')
|
|
self.assertEqual({'answer': 42}, node.extra)
|
|
self.assertEqual(instance_uuid, node.instance_id)
|
|
|
|
node = self.conn.baremetal.update_node('node-name',
|
|
instance_id=None)
|
|
self.assertIsNone(node.instance_id)
|
|
|
|
node = self.conn.baremetal.get_node('node-name')
|
|
self.assertIsNone(node.instance_id)
|
|
|
|
def test_node_list_update_delete(self):
|
|
self.create_node(name='node-name', extra={'foo': 'bar'})
|
|
node = next(n for n in
|
|
self.conn.baremetal.nodes(details=True,
|
|
provision_state='available',
|
|
is_maintenance=False,
|
|
associated=False)
|
|
if n.name == 'node-name')
|
|
self.assertEqual(node.extra, {'foo': 'bar'})
|
|
|
|
# This test checks that resources returned from listing are usable
|
|
self.conn.baremetal.update_node(node, extra={'foo': 42})
|
|
self.conn.baremetal.delete_node(node, ignore_missing=False)
|
|
|
|
def test_node_create_in_enroll_provide(self):
|
|
node = self.create_node(provision_state='enroll')
|
|
self.node_id = node.id
|
|
|
|
self.assertEqual(node.driver, 'fake-hardware')
|
|
self.assertEqual(node.provision_state, 'enroll')
|
|
self.assertIsNone(node.power_state)
|
|
self.assertFalse(node.is_maintenance)
|
|
|
|
self.conn.baremetal.set_node_provision_state(node, 'manage',
|
|
wait=True)
|
|
self.assertEqual(node.provision_state, 'manageable')
|
|
|
|
self.conn.baremetal.set_node_provision_state(node, 'provide',
|
|
wait=True)
|
|
self.assertEqual(node.provision_state, 'available')
|
|
|
|
def test_node_validate(self):
|
|
node = self.create_node()
|
|
# Fake hardware passes validation for all interfaces
|
|
result = self.conn.baremetal.validate_node(node)
|
|
for iface in ('boot', 'deploy', 'management', 'power'):
|
|
self.assertTrue(result[iface].result)
|
|
self.assertFalse(result[iface].reason)
|
|
|
|
def test_node_negative_non_existing(self):
|
|
uuid = "5c9dcd04-2073-49bc-9618-99ae634d8971"
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.get_node, uuid)
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.find_node, uuid,
|
|
ignore_missing=False)
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.delete_node, uuid,
|
|
ignore_missing=False)
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.update_node, uuid,
|
|
name='new-name')
|
|
self.assertIsNone(self.conn.baremetal.find_node(uuid))
|
|
self.assertIsNone(self.conn.baremetal.delete_node(uuid))
|
|
|
|
|
|
class TestBareMetalVif(base.BaseBaremetalTest):
|
|
|
|
min_microversion = '1.28'
|
|
|
|
def setUp(self):
|
|
super(TestBareMetalVif, self).setUp()
|
|
self.node = self.create_node(network_interface='noop')
|
|
self.vif_id = "200712fc-fdfb-47da-89a6-2d19f76c7618"
|
|
|
|
def test_node_vif_attach_detach(self):
|
|
self.conn.baremetal.attach_vif_to_node(self.node, self.vif_id)
|
|
# NOTE(dtantsur): The noop networking driver is completely noop - the
|
|
# VIF list does not return anything of value.
|
|
self.conn.baremetal.list_node_vifs(self.node)
|
|
res = self.conn.baremetal.detach_vif_from_node(self.node, self.vif_id,
|
|
ignore_missing=False)
|
|
self.assertTrue(res)
|
|
|
|
def test_node_vif_negative(self):
|
|
uuid = "5c9dcd04-2073-49bc-9618-99ae634d8971"
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.attach_vif_to_node,
|
|
uuid, self.vif_id)
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.list_node_vifs,
|
|
uuid)
|
|
self.assertRaises(exceptions.ResourceNotFound,
|
|
self.conn.baremetal.detach_vif_from_node,
|
|
uuid, self.vif_id, ignore_missing=False)
|