ddf2a25049
The majority of these were totally broken and unusable because nova doesn't allow you to retrieve a volume attachment by its ID: rather, you need to use a combination of the server and volume IDs. As such, each method should have been taking a combo of a Server object or ID and a *Volume* object or ID, not a VolumeAttachment object or ID. These fixes require rather extensive changes to the method signature, to the point that we've actually added a release note to call this out. We've included some hacky workarounds to avoid breaking existing users for now, giving them time to migrate to the new, improved patterns. In addition, the 'update_volume_attachment' proxy method never worked since updates were forbidden on the resource (via 'allow_commit=False'). This is fixed by changing this value to True. Change-Id: Iaab40ac4cc71f7626063700f476b53f7ffb5f39f Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
53 lines
2.0 KiB
Python
53 lines
2.0 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from openstack import resource
|
|
|
|
|
|
class VolumeAttachment(resource.Resource):
|
|
resource_key = 'volumeAttachment'
|
|
resources_key = 'volumeAttachments'
|
|
base_path = '/servers/%(server_id)s/os-volume_attachments'
|
|
|
|
# capabilities
|
|
allow_create = True
|
|
allow_fetch = True
|
|
allow_commit = True
|
|
allow_delete = True
|
|
allow_list = True
|
|
|
|
_query_mapping = resource.QueryParameters("limit", "offset")
|
|
|
|
#: The ID for the server.
|
|
server_id = resource.URI('server_id')
|
|
#: Name of the device such as, /dev/vdb.
|
|
device = resource.Body('device')
|
|
#: The ID of the attachment.
|
|
id = resource.Body('id')
|
|
# FIXME(stephenfin): This conflicts since there is a server ID in the URI
|
|
# *and* in the body. We need a field that handles both or we need to use
|
|
# different names.
|
|
# #: The UUID of the server
|
|
# server_id = resource.Body('server_uuid')
|
|
#: The ID of the attached volume.
|
|
volume_id = resource.Body('volumeId', alternate_id=True)
|
|
#: The UUID of the associated volume attachment in Cinder.
|
|
attachment_id = resource.Body('attachment_id')
|
|
#: The ID of the block device mapping record for the attachment
|
|
bdm_id = resource.Body('bdm_uuid')
|
|
#: Virtual device tags for the attachment.
|
|
tag = resource.Body('tag')
|
|
#: Indicates whether to delete the volume when server is destroyed
|
|
delete_on_termination = resource.Body('delete_on_termination')
|
|
# attachment_id (in responses) and bdm_id introduced in 2.89
|
|
_max_microversion = '2.89'
|