openstack
/
os-brick
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review+2

(2 comments)

Patch-set: 6
Reviewer: Gerrit User 9535 <9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 9535 \u003c9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Gorka Eguileor replied on the change"}
This commit is contained in:
Gerrit User 9535 2022-05-25 11:49:49 +00:00 committed by Gerrit Code Review
parent da4701a6d7
commit 25dfc996b4
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
8c13de493db134ed8fab160f3ff1d061a245441b Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "58ffa852_40073b58",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 9535
},
"writtenOn": "2022-05-25T11:49:49Z",
"side": 1,
"message": "There\u0027s a missing unit test and I would appreciate if you could add it, but I won\u0027t block the patch since all my concerns have been addressed.\n\nThank you for the effort.",
"revId": "8c13de493db134ed8fab160f3ff1d061a245441b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4ed96c6b_3ab2d450",
"filename": "os_brick/tests/initiator/test_linuxscsi.py",
"patchSetId": 6
},
"lineNbr": 928,
"author": {
"id": 9535
},
"writtenOn": "2022-05-25T11:49:49Z",
"side": 1,
"message": "There\u0027s a case that\u0027s missing. When resizing of the map doesn´t raise the exception on timeout (which I believe was your specific issue).",
"revId": "8c13de493db134ed8fab160f3ff1d061a245441b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}