openstack/os-brick
Code Issues Proposed changes

Remove self.__dict__ for formatting strings

Browse Source 
Following OpenStack Style Guidelines:
http://docs.openstack.org/developer/hacking/#dictionaries-lists
It is not clear as using explicit dictionaries
and help avoid some errors during refactoring.

Change-Id: Iac567648435cd83c3d3fafc1a3e69ea75f2b1624
This commit is contained in:
haobing1 2016-09-01 11:32:03 +08:00
parent ee0e9d166e
commit 261654b059
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/lintstack.py
View File

@ -113,7 +113,12 @@ class LintOutput(object):
def review_str(self): def review_str(self):
return ("File %(filename)s\nLine %(lineno)d:%(line_content)s\n" return ("File %(filename)s\nLine %(lineno)d:%(line_content)s\n"
"%(code)s: %(message)s" % self.__dict__) # noqa:H501 "%(code)s: %(message)s" %
{'filename': self.filename,
'lineno': self.lineno,
'line_content': self.line_content,
'code': self.code,
'message': self.message})
class ErrorKeys(object): class ErrorKeys(object):