From 2e01b2fb2f56fc5cd2b7735364e82024d5f2728c Mon Sep 17 00:00:00 2001 From: Cao Xuan Hoang Date: Mon, 26 Sep 2016 11:45:23 +0700 Subject: [PATCH] Use assertEqual() instead of assertDictEqual() In unittesttools, assertDictEqual() and assertEqual() are implemented by using '!=' operator. But assertEqual() can handle dict, list, set and so on. So we just call assertEqual() to make the tests simpler. Change-Id: If4b7524c07cfac7f705ee466bef02b7de161f8bb --- os_brick/tests/initiator/connectors/test_base_iscsi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os_brick/tests/initiator/connectors/test_base_iscsi.py b/os_brick/tests/initiator/connectors/test_base_iscsi.py index ca7fe82a2..26408c36e 100644 --- a/os_brick/tests/initiator/connectors/test_base_iscsi.py +++ b/os_brick/tests/initiator/connectors/test_base_iscsi.py @@ -48,7 +48,7 @@ class BaseISCSIConnectorTestCase(test_base.TestCase): 'target_iqn': mock.sentinel.iqn, 'target_lun': mock.sentinel.lun, 'extra_property': 'extra_property'} - self.assertDictEqual(expected_props, list_props[0]) + self.assertEqual(expected_props, list_props[0]) def test_get_all_targets(self): connection_properties = {