From 4a475dc8204813587269429de0a92c6212428333 Mon Sep 17 00:00:00 2001 From: Gerrit User 34173 <34173@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 24 May 2022 13:45:12 +0000 Subject: [PATCH] Update patch set 12 Patch Set 12: (8 comments) Patch-set: 12 Attention: {"person_ident":"Gerrit User 34173 \u003c34173@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Lior Friedman replied on the change"} Attention: {"person_ident":"Gerrit User 9535 \u003c9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Lior Friedman replied on the change"} --- a49ab19d54d5661f544d931e649655193cbf6044 | 18 +++ ad2bc618fae467af1655e5e73765a4e859bb3bee | 162 +++++++++++++++++++++++ 2 files changed, 180 insertions(+) diff --git a/a49ab19d54d5661f544d931e649655193cbf6044 b/a49ab19d54d5661f544d931e649655193cbf6044 index 730cc79b4..d313b017f 100644 --- a/a49ab19d54d5661f544d931e649655193cbf6044 +++ b/a49ab19d54d5661f544d931e649655193cbf6044 @@ -294,6 +294,24 @@ "revId": "a49ab19d54d5661f544d931e649655193cbf6044", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "dbd82671_e4300917", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 7 + }, + "lineNbr": 123, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "ed737f13_dae12ae4", + "revId": "a49ab19d54d5661f544d931e649655193cbf6044", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { diff --git a/ad2bc618fae467af1655e5e73765a4e859bb3bee b/ad2bc618fae467af1655e5e73765a4e859bb3bee index 40d4cffd1..29f49fefc 100644 --- a/ad2bc618fae467af1655e5e73765a4e859bb3bee +++ b/ad2bc618fae467af1655e5e73765a4e859bb3bee @@ -40,6 +40,30 @@ "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "6fb31d70_21bc0678", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 522, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "f9957a75_0f022f01", + "range": { + "startLine": 521, + "startChar": 0, + "endLine": 522, + "endChar": 23 + }, + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -63,6 +87,30 @@ "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "b898d090_3bc4bf02", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 576, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "1a442053_8db48600", + "range": { + "startLine": 576, + "startChar": 16, + "endLine": 576, + "endChar": 20 + }, + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -80,6 +128,24 @@ "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "034fab67_91e42735", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 577, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "No, we return true only in case any new connection had been done here.\nI will replace the variable name to any_new_connect.", + "parentUuid": "4d3253c8_04693698", + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -103,6 +169,30 @@ "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "3d12d608_f667704d", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 599, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "38875126_64d2fc39", + "range": { + "startLine": 596, + "startChar": 0, + "endLine": 599, + "endChar": 73 + }, + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -126,6 +216,30 @@ "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "4f826956_e9871a8e", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 602, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "468ff1fe_62b49ef2", + "range": { + "startLine": 600, + "startChar": 0, + "endLine": 602, + "endChar": 20 + }, + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -149,6 +263,30 @@ "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "c06ce89b_e2f2f618", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 632, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "f620b924_29098293", + "range": { + "startLine": 629, + "startChar": 0, + "endLine": 632, + "endChar": 72 + }, + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -171,6 +309,30 @@ }, "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "f3c0c8fb_0872266c", + "filename": "os_brick/initiator/connectors/nvmeof.py", + "patchSetId": 12 + }, + "lineNbr": 633, + "author": { + "id": 34173 + }, + "writtenOn": "2022-05-24T13:45:12Z", + "side": 1, + "message": "Ack", + "parentUuid": "bd86bc16_4448c87d", + "range": { + "startLine": 633, + "startChar": 40, + "endLine": 633, + "endChar": 66 + }, + "revId": "ad2bc618fae467af1655e5e73765a4e859bb3bee", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file