openstack/os-brick
Code Issues Proposed changes

LVM: Remove outdated comment

Browse Source 
-l100%FREE was implemented years ago and is
already used by our code when the LVM version
meets the supports_full_pool_create check.

Change-Id: I8f26e3880429e648e7e985f9c6cb7dff56715727
This commit is contained in:
Eric Harney
2023-04-12 11:31:45 -04:00
parent 9496bb2e47
commit 5926a4d4e2
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
os_brick/local_dev/lvm.py
+1 -5
View File
@@ -518,11 +518,7 @@ class LVM(executor.Executor):
def _calculate_thin_pool_size(self) -> list[str]:
"""Calculates the correct size for a thin pool.
Ideally we would use 100% of the containing volume group and be done.
But the 100%VG notation to lvcreate is not implemented and thus cannot
be used. See https://bugzilla.redhat.com/show_bug.cgi?id=998347
Further, some amount of free space must remain in the volume group for
Some amount of free space must remain in the volume group for
metadata for the contained logical volumes. The exact amount depends
on how much volume sharing you expect.