openstack
/
os-brick
Code Issues Proposed changes

Merge "Change assertTrue(isinstance()) with optimal assert"

This commit is contained in:
Jenkins 2016-11-07 17:51:16 +00:00 committed by Gerrit Code Review
parent 9be0b3d2c4 9b561506d5
commit 5e64248de8
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
os_brick/tests/initiator/connectors/test_rbd.py
View File

@ -89,8 +89,8 @@ class RBDConnectorTestCase(test_connector.ConnectorTestCase):
snapshot=None)
# Ensure expected object is returned correctly
self.assertTrue(isinstance(device_info['path'],
linuxrbd.RBDVolumeIOWrapper))
self.assertIsInstance(device_info['path'],
linuxrbd.RBDVolumeIOWrapper)
@mock.patch('os_brick.initiator.connectors.rbd.tempfile.mkstemp')
def test_create_ceph_conf(self, mock_mkstemp):

4
os_brick/tests/initiator/connectors/test_sheepdog.py
View File

@ -59,8 +59,8 @@ class SheepdogConnectorTestCase(test_connector.ConnectorTestCase):
device_info = sd_connector.connect_volume(self.connection_properties)
# Ensure expected object is returned correctly
self.assertTrue(isinstance(device_info['path'],
linuxsheepdog.SheepdogVolumeIOWrapper))
self.assertIsInstance(device_info['path'],
linuxsheepdog.SheepdogVolumeIOWrapper)
@mock.patch.object(linuxsheepdog.SheepdogVolumeIOWrapper, 'close')
def test_disconnect_volume(self, volume_close):