openstack
/
os-brick
Code Issues Proposed changes

Fix test_connect_volume when skip is bypassed 

If you run the unit tests with a live /dev/disk/by-path
on the system, the tests fall through the skipUnless
decorators.  This exposed some failures in the expected
commands, which were incorrect.   The expected commands
in _test_connect_volume had assumed the multipath set of
commands which included a rescan.

This patch removes the rescan expected tests, as those
are only run for multipath related attaches.

Closes-Bug: #1514611
Change-Id: If2e77af2a63c33df2f190f77b6ba4cea0bc31b31
This commit is contained in:
Walter A. Boring IV 2015-11-09 13:53:53 -08:00 committed by Walter A. Boring IV (hemna)
parent fb4b2e0475
commit 62b01e9b81
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
os_brick/tests/initiator/test_connector.py
View File

@ -357,8 +357,6 @@ class ISCSIConnectorTestCase(ConnectorTestCase):
('iscsiadm -m node -T %s -p %s --login' % (iqn, location)),
('iscsiadm -m node -T %s -p %s --op update'
' -n node.startup -v automatic' % (iqn, location)),
('iscsiadm -m node --rescan'),
('iscsiadm -m session --rescan'),
('blockdev --flushbufs /dev/sdb'),
('tee -a /sys/block/sdb/device/delete'),
('iscsiadm -m node -T %s -p %s --op update'