openstack/os-brick
Code Issues Proposed changes

LVM: Assume LVM >= 2.02.115

Browse Source 
Stop checking for support of lvcreate -l 100%FREE.

LVM 2.02.115 was released in 2015.

Change-Id: Ifd515ac7efd2ed23ef2715dd28e723907c28997e
This commit is contained in:
Eric Harney 2023-08-17 09:36:21 -04:00
parent 368bb38b81
commit 65b61f4a13
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
os_brick/local_dev/lvm.py
View File

@ -245,19 +245,6 @@ class LVM(executor.Executor):
return version_tuple
raise exception.BrickException(message='Cannot parse LVM version')
@property
def supports_full_pool_create(self) -> bool:
"""Property indicating whether 100% pool creation is supported.
Check for LVM version >= 2.02.115.
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=998347
"""
if self.get_lvm_version(self._root_helper) >= (2, 2, 115):
return True
else:
return False
@staticmethod
@utils.retry(retry=utils.retry_if_exit_code, retry_param=139, interval=0.5,
backoff_rate=0.5) # Bug#1901783
@ -481,11 +468,7 @@ class LVM(executor.Executor):
# make sure volume group information is current
self.update_volume_group_info()
if self.supports_full_pool_create:
return ["-l", "100%FREE"]
# leave 5% free for metadata
return ["-L", "%sg" % (self.vg_free_space * 0.95)]
return ["-l", "100%FREE"]
def create_thin_pool(self, name: Optional[str] = None) -> None:
"""Creates a thin provisioning pool for this VG.