Update inline code comment in multipath flush logic

Now that the FC symlink paths /dev/disk/by-id/... and
/dev/mapper/... resolve to the /dev/dm-N device, update
the inline code comment to provide correct information
from maintenance perspective but also not make it
too verbose.
correcting the following parts:
1. only mention of /dev/disk/by-id and not /dev/mapper symlink
2. Not mentioning alias as acceptable parameter
3. 0.9.9 version accepting WWID as valid path

Change-Id: Iac76601fba8f09bc5be4f0ed8041190497c50f41
Signed-off-by: Rajat Dhasmana <rajatdhasmana@gmail.com>
This commit is contained in:
Rajat Dhasmana committed 2026-09-24 00:19:52 +05:30
1 parent 6383277102
commit 7155bf9128
1 file changed
+7 -4
+7 -4
View File
@@ -472,10 +472,13 @@ class LinuxSCSI(executor.Executor):
# after 20 and 40 seconds.
@utils.retry(putils.ProcessExecutionError, interval=20, retries=3)
def flush_multipath_device(self, device_map_name: str) -> None:
# NOTE: The Fibre Channel connector passes a symlink such as
# /dev/disk/by-id/dm-uuid-mpath-<WWID>. That worked before
# multipath-tools 0.9.8, but multipathd now needs the actual block
# device (the /dev/dm-N handle) to be able to remove the map.
# NOTE: FC can pass /dev/disk/by-id/dm-uuid-mpath-<WWID> or
# /dev/mapper/<WWID>; both are symlinks to /dev/dm-N. The
# ``multipath -f`` command delegates removal as ``del map`` to
# multipathd. With upstream multipath-tools 0.9.8, the daemon accepts
# a dm-N kernel name (with or without /dev/) or the current map alias.
# Upstream 0.9.9 also accepts a bare WWID, but neither version accepts
# the FC symlink paths. Resolve absolute paths to /dev/dm-N.
#
# NOTE: we intentionally do retries at the function level so that we
# get a fresh path before trying the flush (device-mapper is