openstack/os-brick
Code Issues Proposed changes

Move os-brick to new hacking 4.0.0

Browse Source 
Change-Id: I24704ab5b74b2f5bdc5b2343ed5ea1ae6acfe973
This commit is contained in:
tushargite96 2021-02-10 20:43:52 +05:30 committed by Brian Rosmaita
parent c710f37d70
commit 7faaf75948
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
os_brick/tests/initiator/connectors/test_rbd.py
View File

@ -196,7 +196,7 @@ class RBDConnectorTestCase(test_base_rbd.RBDConnectorTestMixin,
'--mon_host', '192.168.10.2:6789']
execute_call2 = mock.call(*cmd, root_helper=None, run_as_root=True)
mock_execute.assert_has_calls([execute_call1])
self.assertFalse(execute_call2 in mock_execute.mock_calls)
self.assertNotIn(execute_call2, mock_execute.mock_calls)
expected_info = {'path': '/dev/rbd/pool/image',
'type': 'block'}
self.assertEqual(expected_info, device_info)

6
os_brick/tests/initiator/test_connector.py
View File

@ -197,9 +197,9 @@ class ConnectorTestCase(test_base.TestCase):
@mock.patch('sys.platform', 'win32')
def test_get_connector_mapping_win32(self):
mapping_win32 = connector.get_connector_mapping()
self.assertTrue('ISCSI' in mapping_win32)
self.assertTrue('RBD' in mapping_win32)
self.assertFalse('STORPOOL' in mapping_win32)
self.assertIn('ISCSI', mapping_win32)
self.assertIn('RBD', mapping_win32)
self.assertNotIn('STORPOOL', mapping_win32)
@mock.patch('os_brick.initiator.connector.platform.machine')
def test_get_connector_mapping(self, mock_platform_machine):

2
test-requirements.txt
View File

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
hacking>=3.1.0,<3.2.0 # Apache-2.0
hacking>=4.0.0,<4.1.0 # Apache-2.0
flake8-import-order # LGPLv3
coverage>=5.2.1 # Apache-2.0
ddt>=1.4.1 # MIT