openstack
/
os-brick
Code Issues Proposed changes

Fix _remove_scsi_symlinks_no_links test 

In test_linuxscsi's `_remove_scsi_symlinks_no_links` test we are passing
the list of devices to the method including the /dev prefix, when it
shouldn't have it.

The test result is the same, but it is incorrect to do so as it would be
missing the intent of the test case.

TrivialFix

Change-Id: If0925a5aa3b22248027e6dbae7954e573a1476b8
This commit is contained in:
Gorka Eguileor 2017-09-26 21:19:48 +02:00
parent de89635ab7
commit 806a4c9902
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
os_brick/tests/initiator/test_linuxscsi.py
View File

@ -862,7 +862,7 @@ loop0 0"""
unlink_mock):
paths = ['/dev/disk/by-id/scsi-wwid1', '/dev/disk/by-id/scsi-wwid2']
glob_mock.return_value = paths
self.linuxscsi._remove_scsi_symlinks(['/dev/sdd', '/dev/sde'])
self.linuxscsi._remove_scsi_symlinks(['sdd', 'sde'])
glob_mock.assert_called_once_with('/dev/disk/by-id/scsi-*')
realpath_mock.assert_has_calls([mock.call(g) for g in paths])
unlink_mock.assert_not_called()