openstack
/
os-brick
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(5 comments)

Patch-set: 2
Reviewer: Gerrit User 9535 <9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, a61dab15f1b5c25aba46df14b21e7f04bc1d16c5
Attention: {"person_ident":"Gerrit User 9535 \u003c9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9535\u003e replied on the change"}
This commit is contained in:
Gerrit User 9535 2023-05-26 08:20:45 +00:00 committed by Gerrit Code Review
parent 7ebbbf7a78
commit 885522ec7d
1 changed files with 85 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
be4d4e191e78cb7df0c439054cdb937f9db73ea2
View File

@ -16,6 +16,91 @@
"message": "Thanks Gorka for the review. I\u0027ve modified the logic for the iSCSI and FC connector to pass multipath-dm (dm-*) and we use that to flush and inquire if multipath device exists or not",
"revId": "be4d4e191e78cb7df0c439054cdb937f9db73ea2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "31b1f412_c313f363",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 9535
},
"writtenOn": "2023-05-26T08:20:45Z",
"side": 1,
"message": "Thanks for fixing this issue",
"revId": "be4d4e191e78cb7df0c439054cdb937f9db73ea2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3bd4e803_1eae9672",
"filename": "os_brick/initiator/linuxscsi.py",
"patchSetId": 2
},
"lineNbr": 312,
"author": {
"id": 9535
},
"writtenOn": "2023-05-26T08:20:45Z",
"side": 1,
"message": "-1: We don\u0027t need to get the dm name, we can just use the `mutlipath_dm` directly.",
"revId": "be4d4e191e78cb7df0c439054cdb937f9db73ea2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "037982b6_0667126e",
"filename": "os_brick/initiator/linuxscsi.py",
"patchSetId": 2
},
"lineNbr": 388,
"author": {
"id": 9535
},
"writtenOn": "2023-05-26T08:20:45Z",
"side": 1,
"message": "nit: Mention how the execution call can fail while the multipath is still being flushed by multipathd asynchronously, so the device can actually disappear after a failure.",
"revId": "be4d4e191e78cb7df0c439054cdb937f9db73ea2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4c035de3_45ca6861",
"filename": "os_brick/initiator/linuxscsi.py",
"patchSetId": 2
},
"lineNbr": 390,
"author": {
"id": 9535
},
"writtenOn": "2023-05-26T08:20:45Z",
"side": 1,
"message": "-1: Better use:\n```\n if not os.path.exists(dm_path):\n return\n```",
"revId": "be4d4e191e78cb7df0c439054cdb937f9db73ea2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1e2511d4_cb3ea831",
"filename": "os_brick/initiator/linuxscsi.py",
"patchSetId": 2
},
"lineNbr": 394,
"author": {
"id": 9535
},
"writtenOn": "2023-05-26T08:20:45Z",
"side": 1,
"message": "ditto",
"revId": "be4d4e191e78cb7df0c439054cdb937f9db73ea2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}