openstack
/
os-brick
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 35063 \u003c35063@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35063\u003e replied on the change"}
This commit is contained in:
Gerrit User 35063 2023-05-22 16:17:00 +00:00 committed by Gerrit Code Review
parent a4f65b1dbd
commit a243eaf208
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
4f767da9c5f7773128abf0c05de1787070cdb154
View File

@ -16,6 +16,24 @@
"message": "I\u0027m sorry, looks like I prompted a correction that was not correct, perhaps? The function was renamed to _get_password, but the call remained _get_password_token. This cannot possibly work, or am I missing something?",
"revId": "4f767da9c5f7773128abf0c05de1787070cdb154",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ff6802fb_9cdf09cf",
"filename": "os_brick/initiator/connectors/scaleio.py",
"patchSetId": 5
},
"lineNbr": 336,
"author": {
"id": 35063
},
"writtenOn": "2023-05-22T16:17:00Z",
"side": 1,
"message": "You are right. I ran the unit tests then decided to change the function name. I should have rerun testing to catch the mistake.",
"parentUuid": "dd7ebc6b_8b4aac41",
"revId": "4f767da9c5f7773128abf0c05de1787070cdb154",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}