From aa8cccd1bc1e9475e4b6a0f1fa42c14584da219a Mon Sep 17 00:00:00 2001 From: wanghongxu Date: Tue, 28 Nov 2017 09:58:24 +0800 Subject: [PATCH] set vg_thin_pool_size to float type lvsize is type of str, we need a float type. Change-Id: I2ade0ae1f788f75078b65f701ee051d0f13adbb3 Closes-Bug: #1715041 --- os_brick/local_dev/lvm.py | 2 +- os_brick/tests/local_dev/test_brick_lvm.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/os_brick/local_dev/lvm.py b/os_brick/local_dev/lvm.py index 3e8f32b19..f0aaca153 100644 --- a/os_brick/local_dev/lvm.py +++ b/os_brick/local_dev/lvm.py @@ -463,7 +463,7 @@ class LVM(executor.Executor): if not lv['size'][-1].isdigit(): lvsize = lvsize[:-1] if lv['name'] == self.vg_thin_pool: - self.vg_thin_pool_size = lvsize + self.vg_thin_pool_size = float(lvsize) tpfs = self._get_thin_pool_free_space(self.vg_name, self.vg_thin_pool) self.vg_thin_pool_free_space = tpfs diff --git a/os_brick/tests/local_dev/test_brick_lvm.py b/os_brick/tests/local_dev/test_brick_lvm.py index 25aa14ba4..70fbf52af 100644 --- a/os_brick/tests/local_dev/test_brick_lvm.py +++ b/os_brick/tests/local_dev/test_brick_lvm.py @@ -292,14 +292,14 @@ class BrickLvmTestCase(base.TestCase): self.vg.vg_thin_pool = "test-prov-cap-pool-unit" self.vg.vg_name = 'test-prov-cap-vg-unit' self.assertIsNone(self.vg.create_thin_pool(name=self.vg.vg_thin_pool)) - self.assertEqual("9.50", self.vg.vg_thin_pool_size) + self.assertEqual(9.50, self.vg.vg_thin_pool_size) self.assertEqual(7.6, self.vg.vg_thin_pool_free_space) self.assertEqual(3.0, self.vg.vg_provisioned_capacity) self.vg.vg_thin_pool = "test-prov-cap-pool-no-unit" self.vg.vg_name = 'test-prov-cap-vg-no-unit' self.assertIsNone(self.vg.create_thin_pool(name=self.vg.vg_thin_pool)) - self.assertEqual("9.50", self.vg.vg_thin_pool_size) + self.assertEqual(9.50, self.vg.vg_thin_pool_size) self.assertEqual(7.6, self.vg.vg_thin_pool_free_space) self.assertEqual(3.0, self.vg.vg_provisioned_capacity)