openstack
/
os-brick
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 597 <597@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, b9ca67a69f2cbb472c9d61f329fb6b3d2a2c9cce
Attention: {"person_ident":"Gerrit User 597 \u003c597@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_597\u003e replied on the change"}
This commit is contained in:
Gerrit User 597 2023-05-19 20:16:10 +00:00 committed by Gerrit Code Review
parent 70a10968da
commit d2bf15191f
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
4f767da9c5f7773128abf0c05de1787070cdb154 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "dd7ebc6b_8b4aac41",
"filename": "os_brick/initiator/connectors/scaleio.py",
"patchSetId": 5
},
"lineNbr": 336,
"author": {
"id": 597
},
"writtenOn": "2023-05-19T20:16:10Z",
"side": 1,
"message": "I\u0027m sorry, looks like I prompted a correction that was not correct, perhaps? The function was renamed to _get_password, but the call remained _get_password_token. This cannot possibly work, or am I missing something?",
"revId": "4f767da9c5f7773128abf0c05de1787070cdb154",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}