openstack/os-brick
Code Issues Proposed changes

Update hacking version

Browse Source 
Use latest release 1.1.0 and compatible changes w.r.t pep8

Change-Id: I44910cd34930799dc04166a4e57498c84210f14d
This commit is contained in:
ZhijunWei 2019-01-05 00:42:37 +08:00
parent 959ec5d54d
commit e6ddc92efb
4 changed files with 6 additions and 6 deletions

2
HACKING.rst

@ -1,4 +1,4 @@
brick Style Commandments brick Style Commandments
=============================================== ========================
Read the OpenStack Style Commandments https://docs.openstack.org/hacking/latest/ Read the OpenStack Style Commandments https://docs.openstack.org/hacking/latest/

4
os_brick/initiator/linuxscsi.py

@ -455,8 +455,8 @@ class LinuxSCSI(executor.Executor):
lines = out.strip() lines = out.strip()
lines = lines.split("\n") lines = lines.split("\n")
lines = [line for line in lines lines = [line for line in lines
if not re.match(MULTIPATH_ERROR_REGEX, line) if not re.match(MULTIPATH_ERROR_REGEX, line) and
and len(line)] len(line)]
if lines: if lines:
mdev_name = lines[0].split(" ")[0] mdev_name = lines[0].split(" ")[0]

4
os_brick/initiator/windows/fibre_channel.py

@ -140,8 +140,8 @@ class WindowsFCConnector(win_conn_base.BaseWindowsConnector):
for node_name in hba_mappings: for node_name in hba_mappings:
target_mappings = self._fc_utils.get_fc_target_mappings(node_name) target_mappings = self._fc_utils.get_fc_target_mappings(node_name)
for mapping in target_mappings: for mapping in target_mappings:
if (mapping['port_name'] in target_wwpns if (mapping['port_name'] in target_wwpns and
and mapping['lun'] == target_lun): mapping['lun'] == target_lun):
volume_mappings.append(mapping) volume_mappings.append(mapping)
return volume_mappings return volume_mappings

2
test-requirements.txt

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0 hacking>=1.1.0,<1.2.0 # Apache-2.0
coverage!=4.4,>=4.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0
ddt>=1.0.1 # MIT ddt>=1.0.1 # MIT
reno>=2.5.0 # Apache-2.0 reno>=2.5.0 # Apache-2.0