From 5926a4d4e2516e095293a391579f12c7bfe50400 Mon Sep 17 00:00:00 2001 From: Eric Harney Date: Wed, 12 Apr 2023 11:31:22 -0400 Subject: [PATCH] LVM: Remove outdated comment -l100%FREE was implemented years ago and is already used by our code when the LVM version meets the supports_full_pool_create check. Change-Id: I8f26e3880429e648e7e985f9c6cb7dff56715727 --- os_brick/local_dev/lvm.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/os_brick/local_dev/lvm.py b/os_brick/local_dev/lvm.py index 242ee8574..a82a484b6 100644 --- a/os_brick/local_dev/lvm.py +++ b/os_brick/local_dev/lvm.py @@ -518,11 +518,7 @@ class LVM(executor.Executor): def _calculate_thin_pool_size(self) -> list[str]: """Calculates the correct size for a thin pool. - Ideally we would use 100% of the containing volume group and be done. - But the 100%VG notation to lvcreate is not implemented and thus cannot - be used. See https://bugzilla.redhat.com/show_bug.cgi?id=998347 - - Further, some amount of free space must remain in the volume group for + Some amount of free space must remain in the volume group for metadata for the contained logical volumes. The exact amount depends on how much volume sharing you expect.