openstack/os-brick
Code Issues Proposed changes

Merge "LVM: Remove outdated comment"

Browse Source
This commit is contained in:
Zuul 2023-07-03 16:29:38 +00:00 committed by Gerrit Code Review
commit f7432b56f0
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
os_brick/local_dev/lvm.py
View File

@ -518,11 +518,7 @@ class LVM(executor.Executor):
def _calculate_thin_pool_size(self) -> list[str]: def _calculate_thin_pool_size(self) -> list[str]:
"""Calculates the correct size for a thin pool. """Calculates the correct size for a thin pool.
Ideally we would use 100% of the containing volume group and be done. Some amount of free space must remain in the volume group for
But the 100%VG notation to lvcreate is not implemented and thus cannot
be used. See https://bugzilla.redhat.com/show_bug.cgi?id=998347
Further, some amount of free space must remain in the volume group for
metadata for the contained logical volumes. The exact amount depends metadata for the contained logical volumes. The exact amount depends
on how much volume sharing you expect. on how much volume sharing you expect.