You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Gorka Eguileor 9090cb79ef Use file locks in connectors ... Currently os-brick is using in-process locks that will only prevent concurrent access to critical sections to threads within a single process. But based on the comment from iSCSI it seems like the code assumed that these were file based locks that prevented concurrent access from multiple processes. Mentioned iSCSI comment is being removed because it's not correct that our current retry mechanism will work with connect and disconnect concurrency issues. The reason why we haven't seen errors in Nova is because it runs a single process and locks will be effective. This is probably also not an issue in some transport protocols, such as FC and RBD, and it wouldn't be an issue in iSCSI connections that don't share targets. But for others, such as iSCSI with shared targets and NVMe-OF, not using file locks will create race conditions in the following cases: - More than 1 cinder backend: Because we can have one backend doing a detach in a create volume from image and the other an attach for an offline migration. - Backup/Restore if backup and volume services are running on the same host. - HCI scenarios where cinder volume and nova compute are running on the same host, even if the same lock path if configured. - Glance using Cinder as backend and is running on the same node as cinder-volume or cinder-backup. The problematic race conditions happen because the disconnect will do a logout of the iSCSI target once the connect call has already confirmed that the session to the target exists. We could just add the file locks to iSCSI and NVMe, but I think it's safer to add it to all the connectors and then, after proper testing, we can can change back the locks that can be changed, and remove or reduce the critical section in others. Closes-Bug: #1947370 Change-Id: I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68 (cherry picked from commit 6a43669edc) (cherry picked from commit 19a4820f5c) Conflicts: os_brick/initiator/connectors/iscsi.py (cherry picked from commit 08ddf69d64) Conflicts: os_brick/initiator/connectors/nvmeof.py (cherry picked from commit b03eca8353) Conflicts: os_brick/tests/base.py Conflicts: os_brick/initiator/connectors/iscsi.py		9 months ago
..
encryptors	Skip cryptsetup password quality checking	3 years ago
initiator	Use file locks in connectors	9 months ago
local_dev	Provide setting to ignore lvm descriptor leak warnings	4 years ago
privileged	Fix "Remove VxFlex OS credentials" regression	3 years ago
remotefs	Read mounts from /proc/mounts instead of running mount	3 years ago
tests	Use file locks in connectors	9 months ago
__init__.py	doc: Remove cruft from conf.py	6 years ago
exception.py	iSCSI: Fix flushing after multipath cfg change	2 years ago
executor.py	iSCSI multipath: improve logging on connect	6 years ago
i18n.py	Update and replace http with https for doc links	6 years ago
utils.py	Mask passwords in utils.trace for func params	6 years ago
version.py	Add reno for release notes management	7 years ago