openstack
/
os-brick
Code Issues Proposed changes
os-brick/dd9dc993e1088baf2d1efd88c21...

279 lines
8.8 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d373cac0_5ef53d29",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 9535
},
"writtenOn": "2022-04-12T09:49:51Z",
"side": 1,
"message": "recheck os-brick-src-tempest-lvm-lio-barbican : Error is in self.create_test_server, which is before there is a Cinder attachment, so unrelated to this patch.",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d1b9832a_93f21dbf",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 597
},
"writtenOn": "2022-04-14T22:51:52Z",
"side": 1,
"message": "I have a question. This does not mention dropping the udev rules. So the race is still there and I don\u0027t understand just how exactly this patch fixes bug 1967790.",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e192803b_6f70aa0f",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 246,
"author": {
"id": 597
},
"writtenOn": "2022-04-14T22:51:52Z",
"side": 1,
"message": "kinda bugs me that closing parenthesis is missing :-)",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a9ab3ff3_71481b28",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 246,
"author": {
"id": 9535
},
"writtenOn": "2022-04-19T17:23:41Z",
"side": 1,
"message": "Done",
"parentUuid": "e192803b_6f70aa0f",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8bfe0714_d586a3c4",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 257,
"author": {
"id": 597
},
"writtenOn": "2022-04-14T22:51:52Z",
"side": 1,
"message": "drop \"what\"",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0b7d7a4f_353f2886",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 257,
"author": {
"id": 9535
},
"writtenOn": "2022-04-19T17:23:41Z",
"side": 1,
"message": "Done",
"parentUuid": "8bfe0714_d586a3c4",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b7a3d1ef_8dfda86c",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 262,
"author": {
"id": 597
},
"writtenOn": "2022-04-14T22:51:52Z",
"side": 1,
"message": "Wait, this is not undoing what _symlink_name_from_device did. It could contain underscores in addition to slashes. Now they all went back to slashes.",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bc3f9012_224cb19f",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 262,
"author": {
"id": 9535
},
"writtenOn": "2022-04-19T17:23:41Z",
"side": 1,
"message": "As mentioned on L248 afaik the _ is not used by devices. To the best of my knowledge not on NVMe-oF, iSCSI, or FC.\n\nI tried using the \u0027·\u0027 character, but cryptsetup didn\u0027t like it. I\u0027m open to suggestions on alternative mechanisms to encode the original device path in the symlink name.",
"parentUuid": "b7a3d1ef_8dfda86c",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ba70638a_8fc2e3a2",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 262,
"author": {
"id": 597
},
"writtenOn": "2022-04-19T17:39:04Z",
"side": 1,
"message": "I\u0027m still suspicious. The underscore seems like the first thing I\u0027d reach for if I were to name a device. But apparently we\u0027re lucky in storage. I only see things like\n\n/sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-1/i2c-DELL0A86:00/firmware_node\n\nIt is indeed uncommon (not considering leafs).",
"parentUuid": "bc3f9012_224cb19f",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6b6ac942_dd058439",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 262,
"author": {
"id": 9535
},
"writtenOn": "2022-04-25T13:18:05Z",
"side": 1,
"message": "I\u0027ll replace it with \u0027+\u0027 instead, because I found some udev rules that actually use \u0027_\u0027 in the symlinks\n\n/usr/lib/udev/rules.d/63-scsi-sg3_symlink.rules:12:ENV{SCSI_IDENT_SERIAL}\u003d\u003d\"?*\", ENV{DEVTYPE}\u003d\u003d\"disk\", SYMLINK+\u003d\"disk/by-id/scsi-S$env{SCSI_VENDOR}_$env{SCSI_MODEL}_$env{SCSI_IDENT_SERIAL}\"",
"parentUuid": "ba70638a_8fc2e3a2",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c1a20171_e64f9f9c",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 262,
"author": {
"id": 9535
},
"writtenOn": "2022-05-12T16:17:08Z",
"side": 1,
"message": "Done",
"parentUuid": "6b6ac942_dd058439",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "130ea6d1_510c3cc8",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 273,
"author": {
"id": 4523
},
"writtenOn": "2022-04-14T15:24:52Z",
"side": 1,
"message": "\"they\" typo",
"range": {
"startLine": 273,
"startChar": 64,
"endLine": 273,
"endChar": 69
},
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d9268b35_d319fdf2",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 273,
"author": {
"id": 9535
},
"writtenOn": "2022-04-19T17:23:41Z",
"side": 1,
"message": "Done",
"parentUuid": "130ea6d1_510c3cc8",
"range": {
"startLine": 273,
"startChar": 64,
"endLine": 273,
"endChar": 69
},
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8e9a4d49_20f21d1b",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 301,
"author": {
"id": 597
},
"writtenOn": "2022-04-14T22:51:52Z",
"side": 1,
"message": "I have a bad feeling that a connector somewhere will use a bytes string, because os.path and open() on py3 takes both bytes and str.",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9b28ee04_670cadf3",
"filename": "os_brick/utils.py",
"patchSetId": 2
},
"lineNbr": 301,
"author": {
"id": 9535
},
"writtenOn": "2022-04-19T17:23:41Z",
"side": 1,
"message": "The only place in os-brick where we do a dance with bytes is in the rbd driver (calling convert_str method), and that was done to pass parameters to linuxrbd, not on the device path that is returned.\n\nBut it costs nothing to support both.",
"parentUuid": "8e9a4d49_20f21d1b",
"revId": "dd9dc993e1088baf2d1efd88c21f1accd96adeae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink