39 lines
1.3 KiB
Plaintext
39 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "dd7ebc6b_8b4aac41",
|
|
"filename": "os_brick/initiator/connectors/scaleio.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 336,
|
|
"author": {
|
|
"id": 597
|
|
},
|
|
"writtenOn": "2023-05-19T20:16:10Z",
|
|
"side": 1,
|
|
"message": "I\u0027m sorry, looks like I prompted a correction that was not correct, perhaps? The function was renamed to _get_password, but the call remained _get_password_token. This cannot possibly work, or am I missing something?",
|
|
"revId": "4f767da9c5f7773128abf0c05de1787070cdb154",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ff6802fb_9cdf09cf",
|
|
"filename": "os_brick/initiator/connectors/scaleio.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 336,
|
|
"author": {
|
|
"id": 35063
|
|
},
|
|
"writtenOn": "2023-05-22T16:17:00Z",
|
|
"side": 1,
|
|
"message": "You are right. I ran the unit tests then decided to change the function name. I should have rerun testing to catch the mistake.",
|
|
"parentUuid": "dd7ebc6b_8b4aac41",
|
|
"revId": "4f767da9c5f7773128abf0c05de1787070cdb154",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |