os-brick/3cd2f8c107a33d2097dc4762ff5dd38511638c52

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "ef684064_8601e924",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 35075
      },
      "writtenOn": "2023-03-30T11:33:34Z",
      "side": 1,
      "message": "run-INFINIDAT",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "33223f75_f1c9cc8d",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 7198
      },
      "writtenOn": "2023-04-19T15:01:00Z",
      "side": 1,
      "message": "Code change looks ok but I am not seeing a 3rd Party CI result.",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "bf147ec8_5b544090",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 31779
      },
      "writtenOn": "2023-04-19T15:03:40Z",
      "side": 1,
      "message": "run-DellEMC Powerflex CI",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2e61bb51_f6cf067d",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 597
      },
      "writtenOn": "2023-04-19T15:08:11Z",
      "side": 1,
      "message": "-1 for question",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e8716bf1_338c0066",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 29122
      },
      "writtenOn": "2023-04-20T12:11:30Z",
      "side": 1,
      "message": "Comment inline",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "dd585fe5_daa7d60d",
        "filename": "os_brick/initiator/connectors/scaleio.py",
        "patchSetId": 3
      },
      "lineNbr": 339,
      "author": {
        "id": 597
      },
      "writtenOn": "2023-04-19T15:08:11Z",
      "side": 1,
      "message": "I don\u0027t mind if the vendor\u0027s responsible maintainer wants to change the behavior this way. I\u0027m sure they know better. However, what\u0027s up with this weird defensive programming? The self.server_token is initiated to None, and the code using it expects None. Can _get_password_token() return a server_token that evaluates to False, for example empty, but is not None? Very curious, please explain.",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3b831b73_12816dea",
        "filename": "os_brick/initiator/connectors/scaleio.py",
        "patchSetId": 3
      },
      "lineNbr": 339,
      "author": {
        "id": 35063
      },
      "writtenOn": "2023-05-19T16:49:02Z",
      "side": 1,
      "message": "The problem was that _get_password_token() get overwriting the token everytime get_config was called.",
      "parentUuid": "dd585fe5_daa7d60d",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "d372ef8b_48f5a2c7",
        "filename": "os_brick/initiator/connectors/scaleio.py",
        "patchSetId": 3
      },
      "lineNbr": 339,
      "author": {
        "id": 35063
      },
      "writtenOn": "2023-05-19T16:49:10Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "3b831b73_12816dea",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3cf3d74c_ad126e1e",
        "filename": "releasenotes/notes/bug-2004630-e94616509a51258c.yaml",
        "patchSetId": 3
      },
      "lineNbr": 4,
      "author": {
        "id": 29122
      },
      "writtenOn": "2023-04-20T12:11:30Z",
      "side": 1,
      "message": "In release notes, we need to provide launchpad bug url.\nKindly refer:\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "a0c25f47_147d757c",
        "filename": "releasenotes/notes/bug-2004630-e94616509a51258c.yaml",
        "patchSetId": 3
      },
      "lineNbr": 4,
      "author": {
        "id": 35063
      },
      "writtenOn": "2023-05-19T16:49:02Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "3cf3d74c_ad126e1e",
      "revId": "3cd2f8c107a33d2097dc4762ff5dd38511638c52",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}