openstack/os-collect-config
Code Issues Proposed changes

Ensure full test coverage of cache.

Browse Source
This commit is contained in:
Clint Byrum 2013-06-28 11:47:14 -07:00
parent ccea45fc47
commit 33d869975f
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
os_collect_config/tests/test_cache.py
View File

@ -36,13 +36,18 @@ class TestCache(testtools.TestCase):
cache_dir = os.path.join(cache_root.path, 'cache') cache_dir = os.path.join(cache_root.path, 'cache')
collect.setup_conf() collect.setup_conf()
cfg.CONF(['--cachedir', cache_dir]) cfg.CONF(['--cachedir', cache_dir])
# Never seen, so changed is expected.
(changed, path) = cache.store('foo', {'a': 1}) (changed, path) = cache.store('foo', {'a': 1})
self.assertTrue(changed) self.assertTrue(changed)
self.assertTrue(os.path.exists(cache_dir)) self.assertTrue(os.path.exists(cache_dir))
self.assertTrue(os.path.exists(path)) self.assertTrue(os.path.exists(path))
orig_path = '%s.orig' % path orig_path = '%s.orig' % path
self.assertTrue(os.path.exists(orig_path)) self.assertTrue(os.path.exists(orig_path))
last_path = '%s.last' % path
self.assertFalse(os.path.exists(last_path))
# .orig exists now but not .last so this will shortcut to changed
(changed, path) = cache.store('foo', {'a': 2}) (changed, path) = cache.store('foo', {'a': 2})
self.assertTrue(changed) self.assertTrue(changed)
orig_path = '%s.orig' % path orig_path = '%s.orig' % path
@ -50,6 +55,17 @@ class TestCache(testtools.TestCase):
with open(orig_path) as then: with open(orig_path) as then:
self.assertNotEquals(now.read(), then.read()) self.assertNotEquals(now.read(), then.read())
# Saves the current copy as .last
cache.commit('foo') cache.commit('foo')
last_path = '%s.last' % path
self.assertTrue(os.path.exists(last_path))
# We committed this already, so we should have no changes
(changed, path) = cache.store('foo', {'a': 2}) (changed, path) = cache.store('foo', {'a': 2})
self.assertFalse(changed) self.assertFalse(changed)
cache.commit('foo')
# Fully exercising the line-by-line matching now that a .last exists
(changed, path) = cache.store('foo', {'a': 3})
self.assertTrue(changed)
self.assertTrue(os.path.exists(path))