openstack/os-collect-config
Code Issues Proposed changes

Stop using tearDown.

Browse Source 
TestCase.tearDown doesn't get called if setUp fails, it should never
be used.

Change-Id: Ib960c3f9610d8d8a0624e0c0709afa819e1858ad
This commit is contained in:
Robert Collins 2013-08-16 11:58:35 +12:00
parent 1897ecf001
commit f20f9954db
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
os_collect_config/tests/test_collect.py
View File

@ -46,10 +46,7 @@ class TestCollect(testtools.TestCase):
def setUp(self): def setUp(self):
super(TestCollect, self).setUp() super(TestCollect, self).setUp()
self.useFixture(fixtures.FakeLogger()) self.useFixture(fixtures.FakeLogger())
self.addCleanup(cfg.CONF.reset)
def tearDown(self):
super(TestCollect, self).tearDown()
cfg.CONF.reset()
def _call_main(self, fake_args): def _call_main(self, fake_args):
# make sure we don't run forever! # make sure we don't run forever!