os-collect-config/os_collect_config/tests/test_request.py
Steve Baker 61ff6aaec7 Use TEST-NET-1 for unit tests, not 127.0.0.1
Currently if http requests are not correctly mocked, behaviour of the
unit tests will depend on what happens to be running on localhost.

Jobs like gate-os-collect-config-python27-ubuntu-xenial are currently
broken because discover requests are being made to localhost and
something has change in the environment to cause test failure.

This change does the following:
- replace unit tests addresses from 127.0.0.1 to 192.0.2.1 (TEST-NET-1)
- fix mocking of tests which now stall because 192.0.2.1 isn't accessable
- change the mocking approach to keystoneclient.discover.Discover to
  a simple stub class

Change-Id: I6d9450d6854b9f50dac0f55f54f1ea1d579a27ac
2016-10-12 12:16:52 +13:00

240 lines
7.4 KiB
Python

# Copyright (c) 2013 Hewlett-Packard Development Company, L.P.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
# implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import calendar
import json
import time
import fixtures
from oslo_config import cfg
import requests
import testtools
from testtools import matchers
from os_collect_config import collect
from os_collect_config import exc
from os_collect_config import request
META_DATA = {u'int1': 1,
u'strfoo': u'foo',
u'map_ab': {
u'a': 'apple',
u'b': 'banana',
}}
SOFTWARE_CONFIG_DATA = {
u'old-style': u'value',
u'deployments': [
{
u'inputs': [
{
u'type': u'String',
u'name': u'input1',
u'value': u'value1'
}
],
u'group': 'Heat::Ungrouped',
u'name': 'dep-name1',
u'outputs': None,
u'options': None,
u'config': {
u'config1': 'value1'
}
},
{
u'inputs': [
{
u'type': u'String',
u'name': u'input1',
u'value': u'value1'
}
],
u'group': 'os-apply-config',
u'name': 'dep-name2',
u'outputs': None,
u'options': None,
u'config': {
u'config2': 'value2'
}
},
{
u'inputs': [
{
u'type': u'String',
u'name': u'input1',
u'value': u'value1'
}
],
u'name': 'dep-name3',
u'outputs': None,
u'options': None,
u'config': {
u'config3': 'value3'
}
},
{
u'inputs': [],
u'group': 'ignore_me',
u'name': 'ignore_me_name',
u'outputs': None,
u'options': None,
u'config': 'ignore_me_config'
}
]
}
class FakeResponse(dict):
def __init__(self, text, headers=None):
self.text = text
self.headers = headers
def raise_for_status(self):
pass
class FakeRequests(object):
exceptions = requests.exceptions
class Session(object):
def get(self, url, timeout=None):
return FakeResponse(json.dumps(META_DATA))
def head(self, url, timeout=None):
return FakeResponse('', headers={
'last-modified': time.strftime(
"%a, %d %b %Y %H:%M:%S %Z", time.gmtime())})
class FakeFailRequests(object):
exceptions = requests.exceptions
class Session(object):
def get(self, url, timeout=None):
raise requests.exceptions.HTTPError(403, 'Forbidden')
def head(self, url, timeout=None):
raise requests.exceptions.HTTPError(403, 'Forbidden')
class FakeRequestsSoftwareConfig(object):
class Session(object):
def get(self, url, timeout=None):
return FakeResponse(json.dumps(SOFTWARE_CONFIG_DATA))
def head(self, url, timeout=None):
return FakeResponse('', headers={
'last-modified': time.strftime(
"%a, %d %b %Y %H:%M:%S %Z", time.gmtime())})
class TestRequestBase(testtools.TestCase):
def setUp(self):
super(TestRequestBase, self).setUp()
self.log = self.useFixture(fixtures.FakeLogger())
collect.setup_conf()
cfg.CONF.request.metadata_url = 'http://192.0.2.1:8000/my_metadata'
class TestRequest(TestRequestBase):
def test_collect_request(self):
req_collect = request.Collector(requests_impl=FakeRequests)
self.assertIsNone(req_collect.last_modified)
req_md = req_collect.collect()
self.assertIsNotNone(req_collect.last_modified)
self.assertThat(req_md, matchers.IsInstance(list))
self.assertEqual('request', req_md[0][0])
req_md = req_md[0][1]
for k in ('int1', 'strfoo', 'map_ab'):
self.assertIn(k, req_md)
self.assertEqual(req_md[k], META_DATA[k])
self.assertEqual('', self.log.output)
def test_collect_request_fail(self):
req_collect = request.Collector(requests_impl=FakeFailRequests)
self.assertRaises(exc.RequestMetadataNotAvailable, req_collect.collect)
self.assertIn('Forbidden', self.log.output)
def test_collect_request_no_metadata_url(self):
cfg.CONF.request.metadata_url = None
req_collect = request.Collector(requests_impl=FakeRequests)
self.assertRaises(exc.RequestMetadataNotConfigured,
req_collect.collect)
self.assertIn('No metadata_url configured', self.log.output)
def test_check_fetch_content(self):
req_collect = request.Collector()
now_secs = calendar.timegm(time.gmtime())
now_str = time.strftime("%a, %d %b %Y %H:%M:%S %Z",
time.gmtime(now_secs))
future_secs = calendar.timegm(time.gmtime()) + 10
future_str = time.strftime("%a, %d %b %Y %H:%M:%S %Z",
time.gmtime(future_secs))
past_secs = calendar.timegm(time.gmtime()) - 10
past_str = time.strftime("%a, %d %b %Y %H:%M:%S %Z",
time.gmtime(past_secs))
self.assertIsNone(req_collect.last_modified)
# first run always collects
self.assertEqual(
now_secs,
req_collect.check_fetch_content({'last-modified': now_str}))
# second run unmodified, does not collect
req_collect.last_modified = now_secs
self.assertRaises(exc.RequestMetadataNotAvailable,
req_collect.check_fetch_content,
{'last-modified': now_str})
# run with later date, collects
self.assertEqual(
future_secs,
req_collect.check_fetch_content({'last-modified': future_str}))
# run with earlier date, does not collect
self.assertRaises(exc.RequestMetadataNotAvailable,
req_collect.check_fetch_content,
{'last-modified': past_str})
# run no last-modified header, collects
self.assertIsNone(req_collect.check_fetch_content({}))
class TestRequestSoftwareConfig(TestRequestBase):
def test_collect_request(self):
req_collect = request.Collector(
requests_impl=FakeRequestsSoftwareConfig)
req_md = req_collect.collect()
self.assertEqual(4, len(req_md))
self.assertEqual(
SOFTWARE_CONFIG_DATA['deployments'], req_md[0][1]['deployments'])
self.assertEqual(
('dep-name1', {'config1': 'value1'}), req_md[1])
self.assertEqual(
('dep-name2', {'config2': 'value2'}), req_md[2])
self.assertEqual(
('dep-name3', {'config3': 'value3'}), req_md[3])