openstack/os-ken
Code Issues Proposed changes

lacplib: reduce unnecessary constant

Browse Source 
and correct the inaccurate dispatchers.

Signed-off-by: Yuichi Ito <ito.yuichi0@gmail.com>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This commit is contained in:
Yuichi Ito 2013-11-20 10:15:45 +09:00 committed by FUJITA Tomonori
parent b10491ec73
commit 085717b41f
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ryu/app/simple_switch_lacp.py
View File

@ -16,6 +16,7 @@
import struct import struct
from ryu.base import app_manager from ryu.base import app_manager
from ryu.controller.handler import MAIN_DISPATCHER
from ryu.controller.handler import set_ev_cls from ryu.controller.handler import set_ev_cls
from ryu.ofproto import ofproto_v1_0 from ryu.ofproto import ofproto_v1_0
from ryu.lib import addrconv from ryu.lib import addrconv
@ -64,7 +65,7 @@ class SimpleSwitchLacp(app_manager.RyuApp):
command=ofproto.OFPFC_DELETE) command=ofproto.OFPFC_DELETE)
datapath.send_msg(mod) datapath.send_msg(mod)
@set_ev_cls(lacplib.EventPacketIn, lacplib.LAG_EV_DISPATCHER) @set_ev_cls(lacplib.EventPacketIn, MAIN_DISPATCHER)
def _packet_in_handler(self, ev): def _packet_in_handler(self, ev):
msg = ev.msg msg = ev.msg
datapath = msg.datapath datapath = msg.datapath
@ -100,7 +101,7 @@ class SimpleSwitchLacp(app_manager.RyuApp):
actions=actions) actions=actions)
datapath.send_msg(out) datapath.send_msg(out)
@set_ev_cls(lacplib.EventSlaveStateChanged, lacplib.LAG_EV_DISPATCHER) @set_ev_cls(lacplib.EventSlaveStateChanged, MAIN_DISPATCHER)
def _slave_state_changed_handler(self, ev): def _slave_state_changed_handler(self, ev):
datapath = ev.datapath datapath = ev.datapath
dpid = datapath.id dpid = datapath.id

3
ryu/lib/lacplib.py
View File

@ -31,9 +31,6 @@ from ryu.lib.packet import ethernet
from ryu.lib.packet import slow from ryu.lib.packet import slow
LAG_EV_DISPATCHER = "lacplib"
class EventPacketIn(event.EventBase): class EventPacketIn(event.EventBase):
"""a PacketIn event class using except LACP.""" """a PacketIn event class using except LACP."""
def __init__(self, msg): def __init__(self, msg):