openstack/os-ken
Code Issues Proposed changes

Merge "Do not raise exception if Activity is already stopped"

Browse Source
This commit is contained in:
Zuul 2019-05-07 23:43:37 +00:00 committed by Gerrit Code Review
commit 69158f2446
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
os_ken/services/protocols/bgp/base.py
View File

@ -307,12 +307,11 @@ class Activity(object):
"""Stops all child threads and activities and closes associated
sockets.
Re-initializes this activity to be able to start again.
Raise `ActivityException` if activity is not currently started.
Re-initializes this activity to be able to start again. If the activity
is not started (is already stopped), it will silently return.
"""
if not self.started:
raise ActivityException(desc='Cannot call stop when activity is '
'not started or has been stopped already.')
return
LOG.debug('Stopping activity %s.', self.name)
self._stop_timers()