openstack/os-ken
Code Issues Proposed changes

discard sample/test_simple_switch because of unittest fail

Browse Source 
unittest crashes on commit e5e4b8442:

ERROR: testInit (ryu.tests.unit.sample.test_simple_switch.TestSimpleSwitch)

Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/ryu-test-upstream/workspace/ryu/tests/unit/sample/test_simple_switch.py", line 20, in testInit
    ss = SimpleSwitch()
  File "/var/lib/jenkins/jobs/ryu-test-upstream/workspace/ryu/app/simple_switch.py", line 44, in __init__
    self.mac2port = kwargs['mac2port']
KeyError: 'mac2port'

The simple_switch unittest doesn't test anything anyway so let's
remove it for now.

This also fixes a pip8 error of simple_switch.py that the commit
e5e4b8442 added.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This commit is contained in:
FUJITA Tomonori 2012-06-02 05:20:12 +09:00
parent 25444420ab
commit d9856db46f
2 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ryu/app/simple_switch.py
View File

@ -39,6 +39,7 @@ class SimpleSwitch(app_manager.RyuApp):
_CONTEXTS = {
'mac2port': mac_to_port.MacToPortTable,
}
def __init__(self, *args, **kwargs):
super(SimpleSwitch, self).__init__(*args, **kwargs)
self.mac2port = kwargs['mac2port']

21
ryu/tests/unit/sample/test_simple_switch.py
View File

@ -1,21 +0,0 @@
# vim: tabstop=4 shiftwidth=4 softtabstop=4
import unittest
from nose.tools import ok_, eq_
from ryu.app.simple_switch import SimpleSwitch
import logging
LOG = logging.getLogger(__name__)
class TestSimpleSwitch(unittest.TestCase):
def setUp(self):
pass
def tearDown(self):
pass
def testInit(self):
ss = SimpleSwitch()
ok_(True)