openstack
/
os-net-config
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(2 comments)

Patch-set: 13
This commit is contained in:
Gerrit User 18904 2023-12-15 05:47:45 +00:00 committed by Gerrit Code Review
parent 4bb8ed6658
commit 5f88eedb4b
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
b0c66b19692b6a246b150583ffc3617037f5ffe8 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d78ac451_a756bffb",
"filename": "os_net_config/tests/test_impl_nmstate.py",
"patchSetId": 13
},
"lineNbr": 1132,
"author": {
"id": 18904
},
"writtenOn": "2023-12-15T05:47:45Z",
"side": 1,
"message": "This is already covered in the next test case and hence its not required.",
"revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
d48bb96dc75ff299f244e187772ae268aafbc301
View File

@ -33,6 +33,24 @@
"message": "please create 2 bridges and 2 patch ports so as to replicate the actual use case",
"revId": "d48bb96dc75ff299f244e187772ae268aafbc301",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f39fbbb2_52a672b9",
"filename": "os_net_config/tests/test_impl_nmstate.py",
"patchSetId": 11
},
"lineNbr": 1207,
"author": {
"id": 18904
},
"writtenOn": "2023-12-15T05:47:45Z",
"side": 1,
"message": "The ovs patch port shall have the bridge names as well.",
"parentUuid": "eff1b2c5_aead65eb",
"revId": "d48bb96dc75ff299f244e187772ae268aafbc301",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}