openstack
/
os-net-config
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(3 comments)

Patch-set: 2
This commit is contained in:
Gerrit User 12171 2023-11-08 07:19:37 +00:00 committed by Gerrit Code Review
parent 2658ae789b
commit f435188987
3 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
27915c67c8a4be838b01170c3918ad7ea72f317c
View File

@ -16,6 +16,24 @@
"message": "why this go remove?",
"revId": "27915c67c8a4be838b01170c3918ad7ea72f317c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "016ac8ce_b3a5a3ab",
"filename": "os_net_config/sriov_config.py",
"patchSetId": 1
},
"lineNbr": 369,
"author": {
"id": 12171
},
"writtenOn": "2023-11-08T07:19:37Z",
"side": 0,
"message": "Done",
"parentUuid": "4fb48213_e6506b9f",
"revId": "27915c67c8a4be838b01170c3918ad7ea72f317c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
8060dd52a498eb5bba4790beaa81b4abeb542bb3 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "2323189b_1eb35f58",
"filename": "os_net_config/sriov_config.py",
"patchSetId": 2
},
"lineNbr": 58,
"author": {
"id": 12171
},
"writtenOn": "2023-11-08T07:19:37Z",
"side": 1,
"message": "why this change is needed?",
"revId": "8060dd52a498eb5bba4790beaa81b4abeb542bb3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
9be251c891ad298929eb7053ff469562cae12c88
View File

@ -16,6 +16,24 @@
"message": "why you unbind here?\nthis flow won\u0027t work if vdpa in link 399",
"revId": "9be251c891ad298929eb7053ff469562cae12c88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c3256453_97893eb1",
"filename": "os_net_config/sriov_config.py",
"patchSetId": 1
},
"lineNbr": 396,
"author": {
"id": 12171
},
"writtenOn": "2023-11-08T07:19:37Z",
"side": 1,
"message": "Done",
"parentUuid": "e1487a06_f99c7613",
"revId": "9be251c891ad298929eb7053ff469562cae12c88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}