os-net-config/b0c66b19692b6a246b150583ffc3617037f5ffe8

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "41097147_6689b35b",
        "filename": "os_net_config/impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1305,
      "author": {
        "id": 12398
      },
      "writtenOn": "2023-12-15T08:14:54Z",
      "side": 1,
      "message": "See my other comment in line 1330. I might be missing something, but doesn\u0027t pending_bridge_data only contain a dict of bridge names as keys and {} as values for each?",
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "57e002b8_a147c537",
        "filename": "os_net_config/impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1305,
      "author": {
        "id": 18904
      },
      "writtenOn": "2023-12-15T10:58:22Z",
      "side": 1,
      "message": "The problem we have is that the bridge templates may have the ovs_patch_port as member or may not have. But the patch_port alternatively specifies that its attached to the specific bridge. At the time of parsing the ovs_patch_port if the bridge is not parsed, then we need a place holder to preserve the patch_port members. This variable is used for the same. I think, alternatively we can create the bridge_data entry for the bridge with the details we have and when the actual bridge object is parsed we could add to the partially built bridge_data[bridge.name].",
      "parentUuid": "41097147_6689b35b",
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "512bc2a9_c3b584a4",
        "filename": "os_net_config/impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1329,
      "author": {
        "id": 12398
      },
      "writtenOn": "2023-12-15T08:14:54Z",
      "side": 1,
      "message": "It is possibly confusing to use bridge_data locally here when self.bridge_data also exists. Please change this to just \"bridge\" or anything different from the class variable bridge_data. Changing it to \"bridge\" makes it similar to other *_data variables that get shortened other places in this class.",
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "220da6be_bcdbacfd",
        "filename": "os_net_config/impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1330,
      "author": {
        "id": 12398
      },
      "writtenOn": "2023-12-15T08:14:54Z",
      "side": 1,
      "message": "I\u0027m confused. I don\u0027t see self.pending_bridge_data[patch.port.bridge_name] being assigned anywhere except below, so self.pending_bridge_data would only ever look like this:\n\n{\u0027bridge1\u0027: {}, \u0027bridge2\u0027 {}}\n\nIs that right?",
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3d4169ec_c9047e32",
        "filename": "os_net_config/impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1331,
      "author": {
        "id": 12398
      },
      "writtenOn": "2023-12-15T08:14:54Z",
      "side": 1,
      "message": "Wouldn\u0027t this just result in:\nbridge_data \u003d {}\n?\n\nI\u0027m really not sure if I\u0027m missing something here.",
      "range": {
        "startLine": 1331,
        "startChar": 12,
        "endLine": 1331,
        "endChar": 23
      },
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "8a25e1a8_cd514df8",
        "filename": "os_net_config/impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1334,
      "author": {
        "id": 12398
      },
      "writtenOn": "2023-12-15T08:14:54Z",
      "side": 1,
      "message": "So bridge_data \u003d {}. Why not just use:\nbridge_data \u003d {}\n?",
      "range": {
        "startLine": 1334,
        "startChar": 26,
        "endLine": 1334,
        "endChar": 30
      },
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d78ac451_a756bffb",
        "filename": "os_net_config/tests/test_impl_nmstate.py",
        "patchSetId": 13
      },
      "lineNbr": 1132,
      "author": {
        "id": 18904
      },
      "writtenOn": "2023-12-15T05:47:45Z",
      "side": 1,
      "message": "This is already covered in the next test case and hence its not required.",
      "revId": "b0c66b19692b6a246b150583ffc3617037f5ffe8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}