106 lines
3.6 KiB
Plaintext
106 lines
3.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cb17aa0b_d8e7c5bd",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18904
|
|
},
|
|
"writtenOn": "2023-12-11T14:50:28Z",
|
|
"side": 1,
|
|
"message": "The changes LGTME ! Can you please validate the deployment and reboot scenario for offload and VDPA. In our testing we don\u0027t find the creation of the sriov_bind_config.yaml during reboot and hence sriov_bind service fails.",
|
|
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9912ea6a_700b4e97",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 12398
|
|
},
|
|
"writtenOn": "2023-12-16T03:26:54Z",
|
|
"side": 1,
|
|
"message": "Thanks for these changes, and if someone (sorry, not me) has tested this on bare metal then LGTM.",
|
|
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "40c9557f_4ed23520",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 25241
|
|
},
|
|
"writtenOn": "2023-12-27T20:12:55Z",
|
|
"side": 1,
|
|
"message": "please see the comment below",
|
|
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a2febb9e_8f865e70",
|
|
"filename": "os_net_config/sriov_config.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 112,
|
|
"author": {
|
|
"id": 33688
|
|
},
|
|
"writtenOn": "2023-12-26T07:20:10Z",
|
|
"side": 1,
|
|
"message": "Need better comments for this function. Eg. For switchdev mode - we will get udev events for both the VF and the representator port\nWe will only act for VFs uvdev, and nothing is needed for the rep. ports. There will be a misleading log message in this case: eg. /ens2f0np0_0: Unable to find PF\n\nSo, either we can ignore the rep. port uvde - or update the comments appropriately",
|
|
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "41157378_7e7f1c7c",
|
|
"filename": "os_net_config/sriov_config.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 345,
|
|
"author": {
|
|
"id": 25241
|
|
},
|
|
"writtenOn": "2023-12-27T20:12:55Z",
|
|
"side": 1,
|
|
"message": "@Ivan Kolodyazhny\nFor VF_LAG functionality, you can\u0027t bind the vfs before moving all the pfs to switchdev mode unless you fixed that in the driver. otherwise, it will break the normal VF-LAG functionality.",
|
|
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0671c8b4_ea15a16a",
|
|
"filename": "os_net_config/tests/test_sriov_config.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 478,
|
|
"author": {
|
|
"id": 12398
|
|
},
|
|
"writtenOn": "2023-12-16T03:26:54Z",
|
|
"side": 1,
|
|
"message": "I assume that changing the order of the tests makes this a more realistic simulation of greenfield deployment followed by reboot, is that right?",
|
|
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |