Add test for timing in meta

Also found a bug in the timing code that was exposed by random hash
seeding.
This commit is contained in:
Clint Byrum 2015-11-12 11:24:12 -08:00
parent 4ea517f53f
commit 18a5dbc198
2 changed files with 32 additions and 1 deletions

View File

@ -101,6 +101,7 @@ class AttachmentResult(testtools.StreamResult):
if 'delta_seconds' in values:
client.timing(
'testrun', values['delta_seconds'] * 1000)
continue
for k, v in values.items():
k = '{}.{}'.format(groupname, k)
try:

View File

@ -21,12 +21,13 @@ Tests for `os_performance_tools.counters2statsd`
import json
import mock
import time
from os_performance_tools import counters2statsd
from os_performance_tools.tests import base
class TestOpenStackQaTols(base.TestCase):
class TestCounters2Statsd(base.TestCase):
@mock.patch('statsd.StatsClient')
def test_add_test_run_attachments(self, statsd_mock):
@ -46,3 +47,32 @@ class TestOpenStackQaTols(base.TestCase):
statsd_mock.assert_called_with('localhost', 8125, None)
mock_pipeline.incr.assert_called_with('mysql.Queries', 10)
mock_pipeline.send.assert_called_with()
@mock.patch('statsd.StatsClient')
def test_add_test_run_attachments_meta(self, statsd_mock):
mock_client = mock.MagicMock('statsd_client')
statsd_mock.return_value = mock_client
mock_client.pipeline = mock.MagicMock('statsd_pipeline')
mock_pipeline = mock.MagicMock('Pipeline')
mock_pipeline.incr = mock.MagicMock('statds_incr')
mock_pipeline.timing = mock.MagicMock('statds_timing')
mock_pipeline.send = mock.MagicMock('statds_send')
mock_client.pipeline.return_value = mock_pipeline
fake_counters = {
'__meta__': {
'unixtime': time.time(),
'delta_seconds': 10.5,
},
'mysql': {
'Queries': 50
}
}
fake_counters = json.dumps(fake_counters).encode('utf-8')
self.assertTrue(counters2statsd.AttachmentResult.enabled())
result = counters2statsd.AttachmentResult()
result.status(file_name='counters.json', file_bytes=fake_counters)
result.stopTestRun()
statsd_mock.assert_called_with('localhost', 8125, None)
mock_pipeline.timing.assert_called_with('testrun', 10500)
mock_pipeline.incr.assert_called_with('mysql.Queries', 50)
mock_pipeline.send.assert_called_with()