From 2a22826c58d581c9b41a0a931394be9fb628ca8d Mon Sep 17 00:00:00 2001
From: Matthew Treinish <mtreinish@kortar.org>
Date: Wed, 18 Nov 2015 10:14:10 -0500
Subject: [PATCH] Fail if no tests were successfully executed

This commit adds another sanity check to ensure we didn't have a test
run with just skipped tests.

Change-Id: Ie4bd185c209d9e9230ca8a3f54e8a433e82d9c14
---
 os_testr/subunit_trace.py                     |   6 ++++++
 .../tests/sample_streams/all_skips.subunit    | Bin 0 -> 2453 bytes
 .../tests/sample_streams/successful.subunit   | Bin 0 -> 12563 bytes
 os_testr/tests/test_subunit_trace.py          |  20 ++++++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 os_testr/tests/sample_streams/all_skips.subunit
 create mode 100644 os_testr/tests/sample_streams/successful.subunit

diff --git a/os_testr/subunit_trace.py b/os_testr/subunit_trace.py
index 315d850..1e9b51d 100755
--- a/os_testr/subunit_trace.py
+++ b/os_testr/subunit_trace.py
@@ -354,6 +354,12 @@ def main():
         print_fails(sys.stdout)
     if not args.no_summary:
         print_summary(sys.stdout, elapsed_time)
+
+    # NOTE(mtreinish): Ideally this should live in testtools streamSummary
+    # this is just in place until the behavior lands there (if it ever does)
+    if count_tests('status', '^success$') == 0:
+        print("\nNo tests were successful during the run")
+        exit(1)
     exit(0 if summary.wasSuccessful() else 1)
 
 
diff --git a/os_testr/tests/sample_streams/all_skips.subunit b/os_testr/tests/sample_streams/all_skips.subunit
new file mode 100644
index 0000000000000000000000000000000000000000..54156b5945c9fe6f598e9a788f470e5ead04d8e9
GIT binary patch
literal 2453
zcmdn2&Eyah=Dp_J?d1^-4xYuSC7}h*If=!^3K}J;xdo}kC3=YknR+RSC5iC`Mfu68
z#l@L<>3StViFmMJaeiqLP*l$as3I854gtz(8YV2Bv{}2rVHyq07B5MyDA6y-NzBZ%
zPR>Xy0y^5Zv?R@fttd6II6qG+I1wnAs8C#5P>^3#qL5jvP?TC&npu>Z@;m$Ixy{<G
z4rw%S6(dJ^eo=O6k*?u~4cf0Z1H;t^Y|FZ55>_MyYgT?zv7T3c5;z=P=IVxk!m*7C
zW|1Fm(bsdlLE#og1y>-#>HO@OCqUr@j*aKHR$XuiCMlqjb4rU#Qj6k22{k7Xm?ZU_
zAtE7A0dNSmOyrjXh2R2^+i7MC`C+@>w)`F_Yzt`WK6t1bPrhTJ2nzLVkbPfgX)`!P
zkQC~`<QboonU`2p8K0R44F0^t9B^`V0*iS<g}_07rLi~z6!c4JZx#9Be=uwb6Da&k
zY41pQBpBI!`!9%ygvBd1kQfPh`6;RK=|%aa1xTsi4=Csk5<^M<#Zl~`h)AHRRpduP
zVN7BaA`)ooNJJ!DKmQn9PDcY{{=z5z1t%Ol$jb?tz@i6OU_){MIOR9$uvdZteJb^h
zCO?p6eWUk*0y&lXj)DiOLCA6*H&DtB0b3%yZij;-Nr76BQ<|QcSF9HRp~0aU8>sRR
e6q<chG?V;bY|gTL1`5VFD!K*{evuc}T>=2VP|{EU

literal 0
HcmV?d00001

diff --git a/os_testr/tests/sample_streams/successful.subunit b/os_testr/tests/sample_streams/successful.subunit
new file mode 100644
index 0000000000000000000000000000000000000000..6f3b6641252484c5f40d630d4a28ac08208ba2bf
GIT binary patch
literal 12563
zcmeI2d2ka|9LEczh!vb7j>s?!3uyhLq%<Y8P*4|2DLtSe&Cnv$*G;-<m!`Yx9=3pT
zW6M;=dX>s4ihwX2QcgvIVNkBY0$QLj98-<~kz?c%6@9;#G>cA$)nwC4GSf_w?*4x7
z_xt?5@BQ*#DkECc$)j3_XP<nmbaOvJMhYt{QY1Xf<Qe%sv*XVaS;fjoGV8eliHyX!
z-K;zLgRf6kMu>yE5lizct$thTtguB&Z_&+g`~YVjxKdv1p(?I^J=(}h4l7B6)~Pa+
z%f?ZX%14UhsWGO!Ec|40xEW`@o0Apf;@m7XICW5bN@`NN9Su!NO~?wR{`SDvOKdJ%
zMA;G&6EdkcD3eKKlspQqMQJuPB*~T#Z%?z0Cja6EQw}FPh1Xe$vL|4ZNki%}C`zoN
zjIX=F^Nx&6RvjwODdaT_u%3Hmw@`?)TX(bfExAL?aXiSW7XY~vW8oM#xyvc=PF0dv
z-Z`GiNVBCR*wX89tMUrxHn|witxBxNo5b;oi7j%v)f_e})RW^l3g=yr;wVPSRSQ^N
z!Rhk&ilcZzp>PS{;pb3=98TeV*VI)<=!q{fUdH7?yMtUFf~tg^94L;cjF?W_1NPOb
zZJ{9Lvy!QA;Vk=sN-UIN#OC7lWidWc{9B=r;@EUPuPw-=JF)ZIwoE_m=!<0ILy>p|
zkELE$hYc<g&m_>>BtBRtcz*F*8TyRvW*G=&Tu=)HWHR*j`zpx97N93hByV48e-uQL
z1Qt()NJX*#RV3bN@6P3@aGy#}z0zr|zlQW>vf-gjnt)8a+;v6by)N`dOz{9vNj|Bx
zpcM$nWXq=u?t)Cx19he8Wa+RCyFn+ziOJlE%mKPOvEtsuF4&-B@$_WS;vk+WV9Qs>
z#6v0sVoW;naUjNY^%62;)TZeT<PNgG`QG`nko^oJqSFZc`r&gHAixl_{m1U6N7RP^
zFWIWZBd3tV%8}6g+Q<j-<UOqWD2H`1svCElxPy`rFCcG)?x`Mm3(_<lJ78)%R9TI7
zpijzntn`mY90JheU#po5^gyOT$%2n)?2$v&cYvr9h@MWlzMZxPMpR^End5WsV;XiM
z@l8nROo-;(@;K3W7y4A&r_`)$)Ik7Ob8YE<;93y8O!&ygjCwq3Igrf+vNf4M^`jFE
zA?rG9Jp`GYK!Vuk$~4HXKEvm?Cc7HmGl1*-beC2D&S7xOK3dUFqAPZwg@D$nsj*f%
zH85J9ubFtCfynVjSuy?|Cel+Ofb$uTlo)GXpWT;x7d74h0O4DX1D^vzE;t$Rk?hO8
zSBrq;SmG$_N*JBwA4ym!CFI=$@vM}ltLfhX##O{Nip)09cBgvwk6`<#jl?ptz?;+a
zIZ?!W6%N+Ps4`0lE{cqh6$P171Zh0w7Ac3COZ7Bc%;tVkmN7SWT&#?kNxOnDSS{WB
zyl^X|`ylb+EM883Q(wC4(x^y`lO;V#x@U9APCg(_NiK^U6IEgqSij5&p&UkG6|R8Q
zUPMQk`yymP$Q+AMbTt0!gI~jY^6>K>grZOsdB_MAf3~3r82>^7;+c@<9+3Xz&@I2<
z;QuIOn2vhx9JmptqvI`wvZlzL+p=mjMamIn1{E+?n<hk`G>uav7Pe2t_@$=Es54cH
zR-O~D8#To=T0r`W9C?@}t(IpJYVje1A`2#3NRQ`HWD5vcQ{?4G!{>k^=aR{0N?0ac
zY{(jk*FL`#IYQuBd@FtkGrBGWX>BDVD>+osWJad1k&3Ezh0Ss7Q0z;Jvch2bS<>Y4
zeqYrxw#iVnyT}-4w=1L9`CGO4G!BtQu0gvx+|;2pKZI06kz61_lqVi-jzQ>aVRYKz
z;uanz$cDWz?KH^d`{qnjQ`kFgug%sJHn+DC#o3@u4Q|p<_T_GewbJ_}a<c&nYw#fS
z6{eo4x!%IV1cfCfm6mG?Yo;_cg{>+oeisxrhfEktqr>PK0k2^Jc3rS4Jz*)^3dOXA
z3~NmnYttB(z6!3)`v@ObG_!$2T_5VRdlA(2;--~xtx|t~Dy9l5^;JB;?3x<7f=;Qg
zQuUAaJlmG|NYC@j49~{p%C9O)fZG%Z|6(u89Yd|_*Uh{gsjC~yKj2@+b=?E_^MVq;
zk7Cr%`%hg1idjJM#P&`Vbh3XG>keqW#|Y${w!BwaEhKR=1aax$loBJ2>od&ybAS6r
zat{cZj0NKWVQw&@_Yv&#W9iv4AeapVPm0s3=;8hm{HG4RCqWy+CoF?3PJ=Kmx0&>;
z!S?kz-rO<||J<puMgS=HblAHMP{NPJf{_CsP0OI@k==pjD4=<wy3ckx-andkdL%+z
zakXzx$Y2qS|LUEcA%<AhCwKdJG}#DkNWZ{qpX}@iyg(Di#p|PFzP-?#2b5C5{<+o1
zw#WGg34Wuj9$9(@*znkvW7i6IMF6(+iB#WSGrD2C0f$TI-b=s%syWcueA$m#pV9vX
z$Ubx)Ol{|mYXj>I>Q4H+^WEuN?Mop;(0MoxB$nhEYF(euxAS`^H<o{3cGoh=1k9lG
PFg|`C#n@T1GRpq~QW;6O

literal 0
HcmV?d00001

diff --git a/os_testr/tests/test_subunit_trace.py b/os_testr/tests/test_subunit_trace.py
index 5544636..736dff9 100644
--- a/os_testr/tests/test_subunit_trace.py
+++ b/os_testr/tests/test_subunit_trace.py
@@ -14,6 +14,8 @@
 # under the License.
 
 from datetime import datetime as dt
+import os
+import subprocess
 
 from ddt import data
 from ddt import ddt
@@ -59,3 +61,21 @@ class TestSubunitTrace(base.TestCase):
         }
         with patch.dict(subunit_trace.RESULTS, patched_res, clear=True):
             self.assertEqual(subunit_trace.run_time(), expected_result)
+
+    def test_return_code_all_skips(self):
+        skips_stream = os.path.join(
+            os.path.dirname(os.path.abspath(__file__)),
+            'sample_streams/all_skips.subunit')
+        p = subprocess.Popen(['subunit-trace'], stdin=subprocess.PIPE)
+        with open(skips_stream, 'rb') as stream:
+            p.communicate(stream.read())
+        self.assertEqual(1, p.returncode)
+
+    def test_return_code_normal_run(self):
+        regular_stream = os.path.join(
+            os.path.dirname(os.path.abspath(__file__)),
+            'sample_streams/successful.subunit')
+        p = subprocess.Popen(['subunit-trace'], stdin=subprocess.PIPE)
+        with open(regular_stream, 'rb') as stream:
+            p.communicate(stream.read())
+        self.assertEqual(0, p.returncode)