From b088d21b91dbfda0f18b1e4886f6aa01f2c72cbe Mon Sep 17 00:00:00 2001 From: Matt Riedemann Date: Fri, 12 Aug 2016 17:32:51 -0400 Subject: [PATCH] Add a reminder to remove Route.interface field Nova never sets the Route.interface value to anything but None which fails with an error: "ValueError: Fieldinterface' cannot be None" This looks like a carry-over from the nova.network.model.Route class which has an interface field which is set to None by default but that field is never set to anything else in Nova, neither for nova-network or Neutron. Furthermore, it looks like 'interface' is not something that's in the Route data model in Neutron either. We don't hit this in the gate because the subnets we're testing with don't have host_routes set. The ValueError was fixed in Nova by not setting the attribute: 1d57c1fd53e930b02c3ce0e9914f95ef68dd1f87 This change adds a TODO to remove it in version 2.0 of the Route object. Change-Id: Ib25a79514fe4335f4df222c02fefc9da62fe04ce Closes-Bug: #1612812 --- os_vif/objects/route.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/os_vif/objects/route.py b/os_vif/objects/route.py index 87389fa2..3e00304f 100644 --- a/os_vif/objects/route.py +++ b/os_vif/objects/route.py @@ -25,6 +25,8 @@ class Route(osv_base.VersionedObject): fields = { 'cidr': fields.IPNetworkField(), 'gateway': fields.IPAddressField(), + # TODO(mriedem): This field is never set by Nova, remove it in v2.0 + # of this object. 'interface': fields.StringField(), }