openstack/os-vif
Code Issues Proposed changes

windows: Add missing return

Browse Source 
We were logging in a code path but not setting a return value. This was
passing tests because it seems 'assertFalse' does a falsey check, not a
true boolean False check.

Change-Id: If0156cd4d4c1acbad683873d632ee5afb0b7b7ad
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This commit is contained in:
Stephen Finucane 2020-08-19 10:54:55 +01:00
parent 68c4edba14
commit d6e7521fc4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
os_vif/internal/ip/windows/impl_netifaces.py
View File

@ -30,6 +30,7 @@ class Netifaces(ip_command.IpCommand):
return bool(netifaces.ifaddresses(device)) return bool(netifaces.ifaddresses(device))
except ValueError: except ValueError:
LOG.warning("The device does not exist on the system: %s", device) LOG.warning("The device does not exist on the system: %s", device)
return False
except OSError: except OSError:
LOG.error("Failed to get interface addresses: %s", device) LOG.error("Failed to get interface addresses: %s", device)
return False return False