openstack/os-vif
Code Issues Proposed changes

Fix typo VIFVIFHostDeviceDevType to VIFHostDeviceDevType

Browse Source 
Change-Id: I7a68e4ec0469ca5e676f2e7c88c9535d9747ac29
This commit is contained in:
Moshe Levi 2017-06-17 11:14:29 +03:00
parent 19af4386de
commit db9ef89ee0
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
os_vif/objects/fields.py
View File

@ -70,16 +70,16 @@ class ListOfIPAddressField(fields.AutoTypedField):
AUTO_TYPE = fields.List(fields.IPAddress())
class VIFVIFHostDeviceDevType(fields.Enum):
class VIFHostDeviceDevType(fields.Enum):
ETHERNET = 'ethernet'
GENERIC = 'generic'
ALL = (ETHERNET, GENERIC)
def __init__(self):
super(VIFVIFHostDeviceDevType, self).__init__(
valid_values=VIFVIFHostDeviceDevType.ALL)
super(VIFHostDeviceDevType, self).__init__(
valid_values=VIFHostDeviceDevType.ALL)
class VIFVIFHostDeviceDevTypeField(fields.BaseEnumField):
AUTO_TYPE = VIFVIFHostDeviceDevType()
class VIFHostDeviceDevTypeField(fields.BaseEnumField):
AUTO_TYPE = VIFHostDeviceDevType()

2
os_vif/objects/vif.py
View File

@ -154,7 +154,7 @@ class VIFHostDevice(VIFBase):
# Valid values are ethernet and generic.
# Ethernet is <interface type='hostdev'>
# Generic is <hostdev mode='subsystem' type='pci'>
'dev_type': osv_fields.VIFVIFHostDeviceDevTypeField(),
'dev_type': osv_fields.VIFHostDeviceDevTypeField(),
# The PCI address of the host device
'dev_address': osv_fields.PCIAddressField(),

4
os_vif/tests/test_vif.py
View File

@ -125,7 +125,7 @@ class TestVIFS(base.TestCase):
def test_vif_host_dev_plain(self):
self._test_vif(
objects.vif.VIFHostDevice,
dev_type=objects.fields.VIFVIFHostDeviceDevType.ETHERNET,
dev_type=objects.fields.VIFHostDeviceDevType.ETHERNET,
dev_address="0002:24:12.3")
def test_vif_host_dev_vepa_qbh(self):
@ -151,7 +151,7 @@ object_data = {
'VIFBridge': '1.0-e78d355f3505361fafbf0797ffad484a',
'VIFDirect': '1.0-05c939280f4025fd1f7efb921a835c57',
'VIFGeneric': '1.0-c72e637ed620f0135ea50a9409a3f389',
'VIFHostDevice': '1.0-b3516f5af46ecb9432650e4938ac2643',
'VIFHostDevice': '1.0-bb090f1869c3b4df36efda216ab97a61',
'VIFOpenVSwitch': '1.0-e78d355f3505361fafbf0797ffad484a',
'VIFPortProfile8021Qbg': '1.0-167f305f6e982b9368cc38763815d429',
'VIFPortProfile8021Qbh': '1.0-4b945f07d2666ab00a48d1dc225669b1',