f3de712905
At the moment, in order to migrate a clustered VM, we move the according cluster resource group using the MoveToNewNodeParams WMI method. This method accepts an undocumented 'Parameters' argument, which is then passed to the underlying MoveClusterGroupEx clusapi.dll function. While the latter expects a property list as described at the following link, we were passing the desired migration type directly. https://msdn.microsoft.com/en-us/library/aa371809(v=vs.85).aspx This worked on Windows Server 2012R2 but is causing issues on WS 2016. Resource group end up hanging in a 'Pending' state. This change addresses this issue by using clusapi.dll functions directly, as the according WMI methods are not working, throwing a generic error even though the VMs are migrated properly. Closes-Bug: #1618425 Change-Id: Idfcd3505cbbf2754addeba4f1ebeb880f3b9a56b
199 lines
7.9 KiB
Python
199 lines
7.9 KiB
Python
# Copyright 2015 Cloudbase Solutions SRL
|
|
#
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
Unit tests for the os_win._utils module.
|
|
"""
|
|
|
|
import mock
|
|
from oslotest import base
|
|
|
|
from os_win import _utils
|
|
from os_win import exceptions
|
|
|
|
|
|
class UtilsTestCase(base.BaseTestCase):
|
|
|
|
@mock.patch('oslo_concurrency.processutils.execute')
|
|
def test_execute(self, mock_execute):
|
|
_utils.execute(mock.sentinel.cmd, kwarg=mock.sentinel.kwarg)
|
|
mock_execute.assert_called_once_with(mock.sentinel.cmd,
|
|
kwarg=mock.sentinel.kwarg)
|
|
|
|
def test_parse_server_string(self):
|
|
result = _utils.parse_server_string('::1')
|
|
self.assertEqual(('::1', ''), result)
|
|
result = _utils.parse_server_string('[::1]:8773')
|
|
self.assertEqual(('::1', '8773'), result)
|
|
result = _utils.parse_server_string('2001:db8::192.168.1.1')
|
|
self.assertEqual(('2001:db8::192.168.1.1', ''), result)
|
|
result = _utils.parse_server_string('[2001:db8::192.168.1.1]:8773')
|
|
self.assertEqual(('2001:db8::192.168.1.1', '8773'), result)
|
|
result = _utils.parse_server_string('192.168.1.1')
|
|
self.assertEqual(('192.168.1.1', ''), result)
|
|
result = _utils.parse_server_string('192.168.1.2:8773')
|
|
self.assertEqual(('192.168.1.2', '8773'), result)
|
|
result = _utils.parse_server_string('192.168.1.3')
|
|
self.assertEqual(('192.168.1.3', ''), result)
|
|
result = _utils.parse_server_string('www.example.com:8443')
|
|
self.assertEqual(('www.example.com', '8443'), result)
|
|
result = _utils.parse_server_string('www.example.com')
|
|
self.assertEqual(('www.example.com', ''), result)
|
|
# error case
|
|
result = _utils.parse_server_string('www.exa:mple.com:8443')
|
|
self.assertEqual(('', ''), result)
|
|
result = _utils.parse_server_string('')
|
|
self.assertEqual(('', ''), result)
|
|
|
|
def _get_fake_func_with_retry_decorator(self, side_effect,
|
|
*args, **kwargs):
|
|
func_side_effect = mock.Mock(side_effect=side_effect)
|
|
|
|
@_utils.retry_decorator(*args, **kwargs)
|
|
def fake_func(*_args, **_kwargs):
|
|
return func_side_effect(*_args, **_kwargs)
|
|
|
|
return fake_func, func_side_effect
|
|
|
|
@mock.patch.object(_utils, 'time')
|
|
def test_retry_decorator(self, mock_time):
|
|
err_code = 1
|
|
max_retry_count = 5
|
|
max_sleep_time = 2
|
|
timeout = max_retry_count + 1
|
|
mock_time.time.side_effect = range(timeout)
|
|
|
|
raised_exc = exceptions.Win32Exception(message='fake_exc',
|
|
error_code=err_code)
|
|
side_effect = [raised_exc] * max_retry_count
|
|
side_effect.append(mock.sentinel.ret_val)
|
|
|
|
(fake_func,
|
|
fake_func_side_effect) = self._get_fake_func_with_retry_decorator(
|
|
error_codes=err_code,
|
|
exceptions=exceptions.Win32Exception,
|
|
max_retry_count=max_retry_count,
|
|
max_sleep_time=max_sleep_time,
|
|
timeout=timeout,
|
|
side_effect=side_effect)
|
|
|
|
ret_val = fake_func(mock.sentinel.arg,
|
|
kwarg=mock.sentinel.kwarg)
|
|
self.assertEqual(mock.sentinel.ret_val, ret_val)
|
|
fake_func_side_effect.assert_has_calls(
|
|
[mock.call(mock.sentinel.arg, kwarg=mock.sentinel.kwarg)] *
|
|
(max_retry_count + 1))
|
|
self.assertEqual(max_retry_count + 1, mock_time.time.call_count)
|
|
mock_time.sleep.assert_has_calls(
|
|
[mock.call(sleep_time)
|
|
for sleep_time in [1, 2, 2, 2, 1]])
|
|
|
|
@mock.patch.object(_utils, 'time')
|
|
def _test_retry_decorator_exceeded(self, mock_time, expected_try_count,
|
|
mock_time_side_eff=None,
|
|
timeout=None, max_retry_count=None):
|
|
raised_exc = exceptions.Win32Exception(message='fake_exc')
|
|
mock_time.time.side_effect = mock_time_side_eff
|
|
|
|
(fake_func,
|
|
fake_func_side_effect) = self._get_fake_func_with_retry_decorator(
|
|
exceptions=exceptions.Win32Exception,
|
|
timeout=timeout,
|
|
side_effect=raised_exc)
|
|
|
|
self.assertRaises(exceptions.Win32Exception, fake_func)
|
|
fake_func_side_effect.assert_has_calls(
|
|
[mock.call()] * expected_try_count)
|
|
|
|
def test_retry_decorator_tries_exceeded(self):
|
|
self._test_retry_decorator_exceeded(
|
|
max_retry_count=2,
|
|
expected_try_count=3)
|
|
|
|
def test_retry_decorator_time_exceeded(self):
|
|
self._test_retry_decorator_exceeded(
|
|
mock_time_side_eff=[0, 1, 4],
|
|
timeout=3,
|
|
expected_try_count=1)
|
|
|
|
@mock.patch('time.sleep')
|
|
def _test_retry_decorator_no_retry(self, mock_sleep,
|
|
expected_exceptions=(),
|
|
expected_error_codes=()):
|
|
err_code = 1
|
|
raised_exc = exceptions.Win32Exception(message='fake_exc',
|
|
error_code=err_code)
|
|
fake_func, fake_func_side_effect = (
|
|
self._get_fake_func_with_retry_decorator(
|
|
error_codes=expected_error_codes,
|
|
exceptions=expected_exceptions,
|
|
side_effect=raised_exc))
|
|
|
|
self.assertRaises(exceptions.Win32Exception,
|
|
fake_func, mock.sentinel.arg,
|
|
fake_kwarg=mock.sentinel.kwarg)
|
|
|
|
self.assertFalse(mock_sleep.called)
|
|
fake_func_side_effect.assert_called_once_with(
|
|
mock.sentinel.arg, fake_kwarg=mock.sentinel.kwarg)
|
|
|
|
def test_retry_decorator_unexpected_err_code(self):
|
|
self._test_retry_decorator_no_retry(
|
|
expected_exceptions=exceptions.Win32Exception,
|
|
expected_error_codes=2)
|
|
|
|
def test_retry_decorator_unexpected_exc(self):
|
|
self._test_retry_decorator_no_retry(
|
|
expected_exceptions=(IOError, AttributeError))
|
|
|
|
@mock.patch('time.sleep')
|
|
def test_retry_decorator_explicitly_avoid_retry(self, mock_sleep):
|
|
# Tests the case when there is a function aware of the retry
|
|
# decorator and explicitly requests that no retry should be
|
|
# performed.
|
|
|
|
def func_side_effect(fake_arg, retry_context):
|
|
self.assertEqual(mock.sentinel.arg, fake_arg)
|
|
self.assertEqual(retry_context, dict(prevent_retry=False))
|
|
|
|
retry_context['prevent_retry'] = True
|
|
raise exceptions.Win32Exception(message='fake_exc',
|
|
error_code=1)
|
|
|
|
fake_func, mock_side_effect = (
|
|
self._get_fake_func_with_retry_decorator(
|
|
exceptions=exceptions.Win32Exception,
|
|
side_effect=func_side_effect,
|
|
pass_retry_context=True))
|
|
|
|
self.assertRaises(exceptions.Win32Exception,
|
|
fake_func, mock.sentinel.arg)
|
|
|
|
self.assertEqual(1, mock_side_effect.call_count)
|
|
self.assertFalse(mock_sleep.called)
|
|
|
|
@mock.patch('socket.getaddrinfo')
|
|
def test_get_ips(self, mock_getaddrinfo):
|
|
ips = ['1.2.3.4', '5.6.7.8']
|
|
mock_getaddrinfo.return_value = [
|
|
(None, None, None, None, (ip, 0)) for ip in ips]
|
|
|
|
resulted_ips = _utils.get_ips(mock.sentinel.addr)
|
|
self.assertEqual(ips, resulted_ips)
|
|
|
|
mock_getaddrinfo.assert_called_once_with(
|
|
mock.sentinel.addr, None, 0, 0, 0)
|