From 239b001a14d0c567609ce69c85e0ead73fedbac4 Mon Sep 17 00:00:00 2001 From: sunyandi Date: Fri, 19 Jan 2018 19:36:45 +0800 Subject: [PATCH] Replace 'assertFalse(a in b)' with 'assertNotIn(a, b)' Trivial fix. Change-Id: Id034f3ddb9be5f1a05e99b5d36b3381edda58ddb --- osc_lib/tests/cli/test_client_config.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/osc_lib/tests/cli/test_client_config.py b/osc_lib/tests/cli/test_client_config.py index 087bc3d..1beb959 100644 --- a/osc_lib/tests/cli/test_client_config.py +++ b/osc_lib/tests/cli/test_client_config.py @@ -111,8 +111,8 @@ class TestOSCConfig(utils.TestCase): } ret_config = self.cloud._auth_v2_arguments(config) self.assertEqual('fred', ret_config['auth']['username']) - self.assertFalse('tenant_id' in ret_config['auth']) - self.assertFalse('tenant_name' in ret_config['auth']) + self.assertNotIn('tenant_id', ret_config['auth']) + self.assertNotIn('tenant_name', ret_config['auth']) config = { 'identity_api_version': '3', @@ -124,8 +124,8 @@ class TestOSCConfig(utils.TestCase): } ret_config = self.cloud._auth_v2_arguments(config) self.assertEqual('fred', ret_config['auth']['username']) - self.assertFalse('tenant_id' in ret_config['auth']) - self.assertFalse('tenant_name' in ret_config['auth']) + self.assertNotIn('tenant_id', ret_config['auth']) + self.assertNotIn('tenant_name', ret_config['auth']) config = { 'identity_api_version': '2', @@ -137,7 +137,7 @@ class TestOSCConfig(utils.TestCase): } ret_config = self.cloud._auth_v2_arguments(config) self.assertEqual('id', ret_config['auth']['tenant_id']) - self.assertFalse('tenant_name' in ret_config['auth']) + self.assertNotIn('tenant_name', ret_config['auth']) config = { 'identity_api_version': '2', @@ -148,7 +148,7 @@ class TestOSCConfig(utils.TestCase): }, } ret_config = self.cloud._auth_v2_arguments(config) - self.assertFalse('tenant_id' in ret_config['auth']) + self.assertNotIn('tenant_id', ret_config['auth']) self.assertEqual('name', ret_config['auth']['tenant_name']) def test_auth_v2_ignore_v3(self): @@ -164,7 +164,7 @@ class TestOSCConfig(utils.TestCase): } ret_config = self.cloud._auth_v2_ignore_v3(config) self.assertEqual('fred', ret_config['auth']['username']) - self.assertFalse('project_domain_id' in ret_config['auth']) + self.assertNotIn('project_domain_id', ret_config['auth']) def test_auth_default_domain_not_set(self): config = {