openstack
/
osc-lib
Code Issues Proposed changes

TrivilalFix: Using assertIsNone() instead of assertEqual(None) 

Following OpenStack Style Guidelines[1]: http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..., None)

Change-Id: If09f921565a2252f30fd77324c343272293c3a92
This commit is contained in:
Nam Nguyen Hoai 2016-09-27 16:23:51 +07:00
parent 433ddf03bc
commit 647ed96f54
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osc_lib/tests/test_clientmanager.py
View File

@ -104,7 +104,7 @@ class TestClientManager(utils.TestClientManager):
client_manager = self._make_clientmanager()
self.assertTrue(client_manager.verify)
self.assertEqual(None, client_manager.cacert)
self.assertIsNone(client_manager.cacert)
self.assertTrue(client_manager.is_service_available('network'))
def test_client_manager_password_verify_ca(self):
@ -131,7 +131,7 @@ class TestClientManager(utils.TestClientManager):
)
self.assertFalse(client_manager.verify)
self.assertEqual(None, client_manager.cacert)
self.assertIsNone(client_manager.cacert)
self.assertTrue(client_manager.is_service_available('network'))
def test_client_manager_password_verify_insecure(self):
@ -143,7 +143,7 @@ class TestClientManager(utils.TestClientManager):
)
self.assertFalse(client_manager.verify)
self.assertEqual(None, client_manager.cacert)
self.assertIsNone(client_manager.cacert)
self.assertTrue(client_manager.is_service_available('network'))
def test_client_manager_password_verify_insecure_ca(self):
@ -157,7 +157,7 @@ class TestClientManager(utils.TestClientManager):
# insecure overrides cacert
self.assertFalse(client_manager.verify)
self.assertEqual(None, client_manager.cacert)
self.assertIsNone(client_manager.cacert)
self.assertTrue(client_manager.is_service_available('network'))
def test_client_manager_password_client_cert(self):