osc-lib

openstack/osc-lib

Commit Graph

Author	SHA1	Message	Date
Tang Chen	85c977ac7a	Use assertEqual() instead of assertDictEqual() In unittest2, assertDictEqual() is implemented by using != operator to compare two dicts. So is assertEqual() in testtools. assertEqual() in testtools is able to handle dict, list, set and so on. So we just call assertEqual() to make the unit tests simpler. Change-Id: I5eeeebced716f2065e81d72a9972392ae3a45d89	2016-07-25 15:40:54 +08:00
Huanxuan Ao	876d81ef21	Error handling for KeyValueAction class. The set --property command requires that the input match the "key=value" type, but if the type don't match, the return value will be None, and the command still can be implemented successfully, this may confuse the users. I think we should raise exception if the argument type don't match "key=value". So I make some changes in KeyValueAction class in this patch. Change-Id: If4a00ae6da08bc12362ef2fc82012b42839141f0	2016-06-08 11:41:02 +08:00
Dean Troyer	2bcf7396d8	Begin moving bits to osc_lib * command * commandmanager * exceptions * logs * parseractions * session * timing * utils * test fakes, utils	2016-05-12 16:07:24 -05:00

Author

SHA1

Message

Date

Tang Chen

85c977ac7a

Use assertEqual() instead of assertDictEqual()

In unittest2, assertDictEqual() is implemented by
using != operator to compare two dicts. So is
assertEqual() in testtools. assertEqual() in
testtools is able to handle dict, list, set and so
on. So we just call assertEqual() to make the unit
tests simpler.

Change-Id: I5eeeebced716f2065e81d72a9972392ae3a45d89

2016-07-25 15:40:54 +08:00

Huanxuan Ao

876d81ef21

Error handling for KeyValueAction class.

The set --property command requires that the input match
the "key=value" type, but if the type don't match, the return
value will be None, and the command still can be implemented
successfully, this may confuse the users. I think we should
raise exception if the argument type don't match "key=value".
So I make some changes in KeyValueAction class in this patch.

Change-Id: If4a00ae6da08bc12362ef2fc82012b42839141f0

2016-06-08 11:41:02 +08:00

Dean Troyer

2bcf7396d8

Begin moving bits to osc_lib

* command
* commandmanager
* exceptions
* logs
* parseractions
* session
* timing
* utils
* test fakes, utils

2016-05-12 16:07:24 -05:00

3 Commits