Use hacking import_exceptions for gettextutils._

Instead of using # noqa every time gettextutils._ is used, add an
exception in tox.ini

Change-Id: Iafa8509a38596aac791bd809283f3bd75c638a60

openstack/common/crypto/utils.py

@@ -17,7 +17,7 @@ import base64
 from Crypto.Hash import HMAC
 from Crypto import Random
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 
 

openstack/common/db/exception.py

@@ -16,7 +16,7 @@
 
 """DB related custom exceptions."""
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 
 
 class DBError(Exception):

openstack/common/db/sqlalchemy/migration.py

@@ -52,7 +52,7 @@ from sqlalchemy.schema import UniqueConstraint
 
 from openstack.common.db import exception
 from openstack.common.db.sqlalchemy import session as db_session
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 
 
 get_engine = db_session.get_engine

openstack/common/db/sqlalchemy/session.py

@@ -284,7 +284,7 @@ from sqlalchemy.pool import NullPool, StaticPool
 from sqlalchemy.sql.expression import literal_column
 
 from openstack.common.db import exception
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common import timeutils
 

openstack/common/db/sqlalchemy/test_migrations.py

@@ -23,7 +23,7 @@ from six import moves
 import sqlalchemy
 import sqlalchemy.exc
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common.py3kcompat import urlutils
 from openstack.common import test

openstack/common/db/sqlalchemy/utils.py

@@ -36,7 +36,7 @@ from sqlalchemy import String
 from sqlalchemy import Table
 from sqlalchemy.types import NullType
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 
 from openstack.common import log as logging
 from openstack.common import timeutils

openstack/common/eventlet_backdoor.py

@@ -29,7 +29,7 @@ import eventlet.backdoor
 import greenlet
 from oslo.config import cfg
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 
 help_for_backdoor_port = (

openstack/common/excutils.py

@@ -24,7 +24,7 @@ import traceback
 
 import six
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 
 
 class save_and_reraise_exception(object):

openstack/common/fileutils.py

@@ -20,7 +20,7 @@ import os
 import tempfile
 
 from openstack.common import excutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 
 LOG = logging.getLogger(__name__)

openstack/common/gettextutils.py

@@ -19,7 +19,7 @@ gettext for openstack-common modules.
 
 Usual usage in an openstack.common module:
 
-    from openstack.common.gettextutils import _  # noqa
+    from openstack.common.gettextutils import _
 """
 
 import copy

openstack/common/imageutils.py

@@ -21,7 +21,7 @@ Helper methods to deal with images.
 
 import re
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import strutils
 
 

openstack/common/lockutils.py

@@ -29,7 +29,7 @@ import weakref
 from oslo.config import cfg
 
 from openstack.common import fileutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import local
 from openstack.common import log as logging
 

openstack/common/log.py

@@ -41,7 +41,7 @@ from oslo.config import cfg
 import six
 from six import moves
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import jsonutils
 from openstack.common import local

openstack/common/loopingcall.py

@@ -20,7 +20,7 @@ import sys
 from eventlet import event
 from eventlet import greenthread
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common import timeutils
 

openstack/common/middleware/notifier.py

@@ -23,7 +23,7 @@ import six
 import webob.dec
 
 from openstack.common import context
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common.middleware import base
 from openstack.common.notifier import api

openstack/common/middleware/sizelimit.py

@@ -20,7 +20,7 @@ from oslo.config import cfg
 import webob.dec
 import webob.exc
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common.middleware import base
 
 

openstack/common/notifier/api.py

@@ -19,7 +19,7 @@ import uuid
 from oslo.config import cfg
 
 from openstack.common import context
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import jsonutils
 from openstack.common import log as logging

openstack/common/notifier/rpc_notifier.py

@@ -16,7 +16,7 @@
 from oslo.config import cfg
 
 from openstack.common import context as req_context
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common import rpc
 

openstack/common/notifier/rpc_notifier2.py

@@ -18,7 +18,7 @@
 from oslo.config import cfg
 
 from openstack.common import context as req_context
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common import rpc
 

openstack/common/periodic_task.py

@@ -17,7 +17,7 @@ import time
 from oslo.config import cfg
 import six
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common import timeutils
 

openstack/common/policy.py

@@ -61,7 +61,7 @@ from oslo.config import cfg
 import six
 
 from openstack.common import fileutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import jsonutils
 from openstack.common import log as logging
 from openstack.common.py3kcompat import urlutils

openstack/common/processutils.py

@@ -26,7 +26,7 @@ import signal
 from eventlet.green import subprocess
 from eventlet import greenthread
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 
 

openstack/common/quota.py

@@ -21,7 +21,7 @@ import datetime
 from oslo.config import cfg
 import six
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import log as logging
 from openstack.common import timeutils

openstack/common/rpc/__init__.py

@@ -27,7 +27,7 @@ import inspect
 
 from oslo.config import cfg
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import local
 from openstack.common import log as logging

openstack/common/rpc/amqp.py

@@ -37,7 +37,7 @@ import six
 
 
 from openstack.common import excutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import local
 from openstack.common import log as logging
 from openstack.common.rpc import common as rpc_common

openstack/common/rpc/common.py

@@ -22,7 +22,7 @@ import traceback
 from oslo.config import cfg
 import six
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import jsonutils
 from openstack.common import local

openstack/common/rpc/impl_kombu.py

@@ -29,7 +29,7 @@ from oslo.config import cfg
 import six
 
 from openstack.common import excutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import network_utils
 from openstack.common.rpc import amqp as rpc_amqp
 from openstack.common.rpc import common as rpc_common

openstack/common/rpc/impl_qpid.py

@@ -23,7 +23,7 @@ from oslo.config import cfg
 import six
 
 from openstack.common import excutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import jsonutils
 from openstack.common import log as logging

openstack/common/rpc/impl_zmq.py

@@ -27,7 +27,7 @@ import six
 from six import moves
 
 from openstack.common import excutils
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import jsonutils
 from openstack.common.rpc import common as rpc_common

openstack/common/rpc/matchmaker.py

@@ -21,7 +21,7 @@ import contextlib
 import eventlet
 from oslo.config import cfg
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 
 

openstack/common/rpc/matchmaker_ring.py

@@ -21,7 +21,7 @@ import json
 
 from oslo.config import cfg
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common.rpc import matchmaker as mm
 

openstack/common/rpc/service.py

@@ -15,7 +15,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 from openstack.common import rpc
 from openstack.common.rpc import dispatcher as rpc_dispatcher

openstack/common/service.py

@@ -38,7 +38,7 @@ from eventlet import event
 from oslo.config import cfg
 
 from openstack.common import eventlet_backdoor
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import importutils
 from openstack.common import log as logging
 from openstack.common import threadgroup

openstack/common/sslutils.py

@@ -17,7 +17,7 @@ import ssl
 
 from oslo.config import cfg
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 
 
 ssl_opts = [

openstack/common/strutils.py

@@ -23,7 +23,7 @@ import unicodedata
 
 import six
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 
 
 # Used for looking up extensions of text

openstack/common/versionutils.py

@@ -20,7 +20,7 @@ Helpers for comparing version strings.
 import functools
 import pkg_resources
 
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common import log as logging
 
 

tests/unit/rpc/common.py

@@ -24,7 +24,7 @@ import time
 import eventlet
 
 from openstack.common.fixture import config
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from openstack.common.rpc import common as rpc_common
 from openstack.common.rpc import dispatcher as rpc_dispatcher
 from openstack.common import test

tests/unit/rpc/test_zmq.py

@@ -28,7 +28,7 @@ from six import moves
 
 from openstack.common.fixture import config
 from openstack.common.fixture import moxstubout
-from openstack.common.gettextutils import _  # noqa
+from openstack.common.gettextutils import _
 from tests.unit.rpc import common
 
 try:

tox.ini

@@ -41,3 +41,7 @@ commands = {posargs}
 
 [testenv:pyflakes]
 commands = flake8
+
+
+[hacking]
+import_exceptions = openstack.common.gettextutils._