Update patch set 7

Patch Set 7: Code-Review-1

(2 comments)

Patch-set: 7
Reviewer: Gerrit User 10850 <10850@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 10850 2018-03-21 22:55:51 +00:00 committed by Gerrit Code Review
parent 289973524a
commit c376023d90
1 changed files with 41 additions and 0 deletions

View File

@ -288,6 +288,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df7087c5_b597d790",
"filename": "specs/rocky/oslo-healthcheck-middleware.rst",
"patchSetId": 7
},
"lineNbr": 100,
"author": {
"id": 10850
},
"writtenOn": "2018-03-21T22:55:51Z",
"side": 1,
"message": "NIT: initialiZing",
"range": {
"startLine": 100,
"startChar": 2,
"endLine": 100,
"endChar": 14
},
"revId": "e21c5f57482ba2a12f1f1823baaf447f58a26fcb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df7087c5_c0d3cb37",
@ -647,6 +670,24 @@
"revId": "e21c5f57482ba2a12f1f1823baaf447f58a26fcb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df7087c5_ab71b3e0",
"filename": "specs/rocky/oslo-healthcheck-middleware.rst",
"patchSetId": 7
},
"lineNbr": 262,
"author": {
"id": 10850
},
"writtenOn": "2018-03-21T22:55:51Z",
"side": 1,
"message": "As said above we mostly need a response which signifies Healthy/Unhealthy. If we follow the k8s example they also support simple TCP endpoint among other things. I think having some alternative TCP socket might be a. more lightweight alternative we can explore for simpler services. I really think a big selling point of this proposal is uniformity so excluding services because HTTP is too heavy fro them doesn\u0027t seem right.\n\n@johnsom despite most of our services using the DB it\u0027s conceivable that even that might be too heavy for some.",
"parentUuid": "df7087c5_37e59d38",
"revId": "e21c5f57482ba2a12f1f1823baaf447f58a26fcb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}