From d9500e1564669389f1274f4a3954b3919b716b71 Mon Sep 17 00:00:00 2001 From: Ben Nemec Date: Fri, 22 Feb 2019 17:42:20 +0000 Subject: [PATCH] Remove dogpile kwarg test This test is verifying dogpile behavior[0], not oslo.cache behavior. Since dogpile has broken this behavior, we are now broken with no real way to fix it on our end. We should leave dogpile testing to dogpile and only run unit tests that test our code. 0: The ValueError we are asserting on comes from dogpile.cache: https://github.com/sqlalchemy/dogpile.cache/blob/1b4ab2d3e08b9fe606bf723299f815207dacceaa/dogpile/cache/util.py#L35 Change-Id: I5ff1bd473167b84f64312efb659e26230605b480 --- oslo_cache/tests/test_cache.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/oslo_cache/tests/test_cache.py b/oslo_cache/tests/test_cache.py index 36636d95..333fbb65 100644 --- a/oslo_cache/tests/test_cache.py +++ b/oslo_cache/tests/test_cache.py @@ -315,14 +315,6 @@ class CacheRegionTest(BaseTestCase): self.config_fixture.conf, "bogus") - def test_function_key_generator_with_kwargs(self): - cacheable_function = self._get_cacheable_function() - - self.config_fixture.config(group='cache', enabled=True) - self.assertRaises(ValueError, - cacheable_function, - value=0, foo=self.test_value) - def test_kwarg_function_key_generator_no_kwargs(self): cacheable_function = self._get_cacheable_function( region=self.region_kwargs)