openstack/oslo.cache
Code Issues Proposed changes

Add bug comment and fix nits

Browse Source 
Change-Id: Icb2b62d7d51cac652f9958ee094fef78a8ac9574
This commit is contained in:
Hervé Beraud
2021-01-25 19:19:04 +01:00
parent a437b219ac
commit e5d0b2019e
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
oslo_cache/core.py
View File

@@ -140,9 +140,9 @@ def _build_cache_config(conf):
# backends. Use setdefault for url to support old-style setting through # backends. Use setdefault for url to support old-style setting through
# backend_argument=url:127.0.0.1:11211 # backend_argument=url:127.0.0.1:11211
# #
# NOTE(morgan): Explicitly set flush_on_reconnect for pooled # NOTE(morgan): If requested by config, 'flush_on_reconnect' will be set
# connections. This should ensure that stale data is never consumed # for pooled connections. This can ensure that stale data is never
# from a server that pops in/out due to a network partition # consumed from a server that pops in/out due to a network partition
# or disconnect. # or disconnect.
# #
# See the help from python-memcached: # See the help from python-memcached:

7
releasenotes/notes/bug-1888394-5a53e7a9cb25375b.yaml
View File

@@ -7,16 +7,15 @@ fixes:
possible that the server will contain stale data. To avoid this, param possible that the server will contain stale data. To avoid this, param
flush_on_reconnect was used in code. flush_on_reconnect was used in code.
But unfortunatelly this option is causing another issue. But unfortunately this option is causing another issue.
If memcache server disappears, or client had broken connection to memcache server, If memcache server disappears, or client had broken connection to memcache server,
clients start to flush server on reconnect. clients start to flush server on reconnect.
This means that network connections will go UP and can cause server to be overloaded This means that network connections will go UP and can cause server to be overloaded
until memcache will be unresponsive. until memcache will be unresponsive.
Simply said this option can cause loop of flushs and overloaded memcached servers. Simply said this option can cause loops of flushes and overloaded memcached servers.
This change is moving optional parameter `flush_on_reconnect` to oslo.cache config. This change is moving optional parameter ``flush_on_reconnect`` to oslo.cache config.
features: features:
- Configuration option ``memcache_pool_flush_on_reconnect`` added to control - Configuration option ``memcache_pool_flush_on_reconnect`` added to control
if flush will be sent to memcached server after reconnect. if flush will be sent to memcached server after reconnect.