diff --git a/oslo_cache/core.py b/oslo_cache/core.py index a41cb074..6279166c 100644 --- a/oslo_cache/core.py +++ b/oslo_cache/core.py @@ -140,9 +140,9 @@ def _build_cache_config(conf): # backends. Use setdefault for url to support old-style setting through # backend_argument=url:127.0.0.1:11211 # - # NOTE(morgan): Explicitly set flush_on_reconnect for pooled - # connections. This should ensure that stale data is never consumed - # from a server that pops in/out due to a network partition + # NOTE(morgan): If requested by config, 'flush_on_reconnect' will be set + # for pooled connections. This can ensure that stale data is never + # consumed from a server that pops in/out due to a network partition # or disconnect. # # See the help from python-memcached: diff --git a/releasenotes/notes/bug-1888394-5a53e7a9cb25375b.yaml b/releasenotes/notes/bug-1888394-5a53e7a9cb25375b.yaml index 4bda512e..bfa8cb81 100644 --- a/releasenotes/notes/bug-1888394-5a53e7a9cb25375b.yaml +++ b/releasenotes/notes/bug-1888394-5a53e7a9cb25375b.yaml @@ -7,16 +7,15 @@ fixes: possible that the server will contain stale data. To avoid this, param flush_on_reconnect was used in code. - But unfortunatelly this option is causing another issue. + But unfortunately this option is causing another issue. If memcache server disappears, or client had broken connection to memcache server, clients start to flush server on reconnect. This means that network connections will go UP and can cause server to be overloaded until memcache will be unresponsive. - Simply said this option can cause loop of flushs and overloaded memcached servers. - This change is moving optional parameter `flush_on_reconnect` to oslo.cache config. - + Simply said this option can cause loops of flushes and overloaded memcached servers. + This change is moving optional parameter ``flush_on_reconnect`` to oslo.cache config. features: - Configuration option ``memcache_pool_flush_on_reconnect`` added to control if flush will be sent to memcached server after reconnect.