{ "comments": [ { "unresolved": true, "key": { "uuid": "01f88dfc_16d9d11c", "filename": "/COMMIT_MSG", "patchSetId": 9 }, "lineNbr": 13, "author": { "id": 36624 }, "writtenOn": "2024-02-02T12:15:26Z", "side": 1, "message": "What\u0027s a correct way of providing Redis username and password?", "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "a765f182_593c3e52", "filename": "/COMMIT_MSG", "patchSetId": 9 }, "lineNbr": 13, "author": { "id": 9816 }, "writtenOn": "2024-02-02T12:19:11Z", "side": 1, "message": "Use memcache_username and memcache_password.", "parentUuid": "01f88dfc_16d9d11c", "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "94b4fb77_7b017840", "filename": "/COMMIT_MSG", "patchSetId": 9 }, "lineNbr": 13, "author": { "id": 9816 }, "writtenOn": "2024-02-02T12:26:29Z", "side": 1, "message": "Actually memcache connections do not use username so setting memcache_password should be enough. The option name is confusing so we may want to rename it in the future.", "parentUuid": "a765f182_593c3e52", "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "504e5381_3a870155", "filename": "/COMMIT_MSG", "patchSetId": 9 }, "lineNbr": 13, "author": { "id": 36624 }, "writtenOn": "2024-02-02T12:33:45Z", "side": 1, "message": "thank you", "parentUuid": "94b4fb77_7b017840", "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "d7dcd1e8_de042113", "filename": "/PATCHSET_LEVEL", "patchSetId": 9 }, "lineNbr": 0, "author": { "id": 36624 }, "writtenOn": "2024-02-02T12:15:26Z", "side": 1, "message": "I cannot run this in Kolla using the example config from commit message.", "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "29745f56_b14119c2", "filename": "oslo_cache/core.py", "patchSetId": 9 }, "lineNbr": 261, "author": { "id": 36624 }, "writtenOn": "2024-02-02T12:15:26Z", "side": 1, "message": "What is \u0027client_kwargs\u0027? AFAIK there\u0027s no such thing in [redis-py](https://github.com/search?q\u003drepo%3Aredis%2Fredis-py%20client_kwargs\u0026type\u003dcode)\nor [dogpile.cache](https://github.com/search?q\u003drepo%3Asqlalchemy%2Fdogpile.cache%20client_kwargs\u0026type\u003dcode) source code. Am I missing something here or did you mean `connection_kwargs`", "range": { "startLine": 261, "startChar": 20, "endLine": 261, "endChar": 33 }, "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "a2b4a6d9_9be3bc86", "filename": "oslo_cache/core.py", "patchSetId": 9 }, "lineNbr": 261, "author": { "id": 9816 }, "writtenOn": "2024-02-02T12:19:11Z", "side": 1, "message": "This needs to be connection_kwargs. I\u0027ll fix it soon.", "parentUuid": "29745f56_b14119c2", "range": { "startLine": 261, "startChar": 20, "endLine": 261, "endChar": 33 }, "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "b8b2ab73_b0533326", "filename": "oslo_cache/core.py", "patchSetId": 9 }, "lineNbr": 261, "author": { "id": 9816 }, "writtenOn": "2024-02-02T12:26:29Z", "side": 1, "message": "Done", "parentUuid": "a2b4a6d9_9be3bc86", "range": { "startLine": 261, "startChar": 20, "endLine": 261, "endChar": 33 }, "revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }