a2e876b829
Patch Set 3:
(1 comment)
Patch-set: 3
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32553 \u003c32553@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
51 lines
1.9 KiB
Plaintext
51 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f4eaca76_c7723190",
|
|
"filename": "oslo_cache/core.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 32553
|
|
},
|
|
"writtenOn": "2024-01-31T16:54:59Z",
|
|
"side": 1,
|
|
"message": "I\u0027m not sure using regex to parse/validate IPv4|6 is a good idea. Why not use the standard library function for that? (it might require more work, but also provide a cleaner interface).\nhttps://docs.python.org/3/library/ipaddress.html\n\nalso this conflates \"localhost\" with IPv4, when localhost also can resolve to an IPv6 address.",
|
|
"range": {
|
|
"startLine": 105,
|
|
"startChar": 4,
|
|
"endLine": 109,
|
|
"endChar": 46
|
|
},
|
|
"revId": "1c654d513eab184ca4e3e3b7b0fc47270f953c01",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f7a6f0ce_5a3dc8c6",
|
|
"filename": "oslo_cache/core.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-01-31T17:30:56Z",
|
|
"side": 1,
|
|
"message": "We can implement a string pattern validation for address/host part but I\u0027m not too sure if we get much benefit by complicating the logic here. The current version focus on the format how address/host and port are combined in a field and I think it\u0027s enough (or even too much ?).\n\nHere I intended hostname by localhost, instead just a host. Probably I can update the comment to explicitly show that (s/host/host name/, I mean)",
|
|
"parentUuid": "f4eaca76_c7723190",
|
|
"range": {
|
|
"startLine": 105,
|
|
"startChar": 4,
|
|
"endLine": 109,
|
|
"endChar": 46
|
|
},
|
|
"revId": "1c654d513eab184ca4e3e3b7b0fc47270f953c01",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |